DietPi-Software | ADS-B Feeder: Harden uninstall and fix beta tags #6661
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The tag format upstream was extended - this tracks that change. Signed-off-by: Dirk Hohndel <[email protected]>
Don't install the unused update timer - we don't use that as an app. Remove the adsb-docker service on uninstall. Don't prune the docker images - that might remove images we don't own. Signed-off-by: Dirk Hohndel <[email protected]>
MichaIng
reviewed
Oct 8, 2023
MichaIng
reviewed
Oct 8, 2023
applying suggestion via the web interface - I know I will regret this... Co-authored-by: MichaIng <[email protected]>
MichaIng
reviewed
Oct 8, 2023
The names should be specific enough for this approach. Signed-off-by: Dirk Hohndel <[email protected]>
This should allow us to clean up the various docker images that might have been installed. Signed-off-by: Dirk Hohndel <[email protected]>
dirkhh
commented
Oct 8, 2023
dirkhh
commented
Oct 8, 2023
This is 100% written by @MichaIng - I'm just adding to the branch. Signed-off-by: Dirk Hohndel <[email protected]>
- CHANGELOG | ADS-B Feeder: The uninstall has been hardened to rule out the removal of unused Docker images which were not created by ADS-B Feeder. Furthermore, beta tags are now correctly shown in the version string. Many thanks to @andreagdipaolo for reporting a related issue and @dirkhh for implementing the enhancement: MichaIng#6587 (comment)
MichaIng
changed the title
MichaIng
approved these changes
Oct 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses the concern #6587 (comment) about the ADS-B Feeder app sometimes issuing a docker prune which potentially removes data that we didn't own. The corresponding change to the upstream code was submitted as well: dirkhh/adsb-feeder-image@0136d44
This also adapts to a recent change in the tag semantic in the ADS-B Feeder image upstream and cleans up the services handling.