Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DietPi-Sofware | MediaWiki: A collaboration and documentation platform #6443

Merged
merged 12 commits into from
Jun 25, 2023

Conversation

Joulinar
Copy link
Collaborator

  • add new software title ID 141

@Joulinar Joulinar self-assigned this Jun 19, 2023
@Joulinar Joulinar added this to the v8.19 milestone Jun 19, 2023
@Joulinar Joulinar marked this pull request as draft June 19, 2023 09:30
dietpi/dietpi-software Outdated Show resolved Hide resolved
dietpi/dietpi-software Outdated Show resolved Hide resolved
dietpi/dietpi-software Outdated Show resolved Hide resolved
dietpi/dietpi-software Outdated Show resolved Hide resolved
@MichaIng MichaIng changed the title DietPi-Sofware | MediaWiki DietPi-Sofware | MediaWiki: A collaboration and documentation platform Jun 19, 2023
dietpi/dietpi-software Outdated Show resolved Hide resolved
@MichaIng MichaIng marked this pull request as ready for review June 24, 2023 21:37
@MichaIng
Copy link
Owner

@Joulinar
Ready from your end? Running install tests: https://github.com/MichaIng/DietPi/actions/runs/5366345297
And will do a quick test on VM afterwards to have a look at PHP log and possible admin panel warnings.

@Joulinar
Copy link
Collaborator Author

Yes from my side I'm done. Ready for testing.

@MichaIng
Copy link
Owner

MichaIng commented Jun 25, 2023

  • Added all required PHP modules to be installed and enabled
  • Added Nginx and Lighttpd configs to set a security header for the image upload directory
  • Lighttpd: Find out how to unset a fastcgi.server directive for a sub directory, to prevent PHP scripts within the image upload dir form being executed. On Nginx this is the case automatically by simply having the /wiki location block added for the header, on Apache this is done via .htaccess shipped with MediaWiki.
  • Add access denial directives for certain sub directories to Nginx and Lighttpd configs, following the .htaccess files shipped with the archive

Joulinar and others added 11 commits June 25, 2023 20:18
DietPi-Sofware | MediaWiki - add new software title
DietPi-Software | MediaWiki - shellcheck
DietPi-Software | MediaWiki - shellcheck
DietPi-Software | MediaWiki - For MediaWiki, at least PHP 7.4.3 is required. Therefore, installation on Buster is not supported.
DietPi-Software | MediaWiki - small adjustemt

Co-authored-by: MichaIng <[email protected]>
DietPi-Software | MediaWiki - small adjustment

Co-authored-by: MichaIng <[email protected]>
DietPi-Software | MediaWiki - small adjustment

Co-authored-by: MichaIng <[email protected]>
DietPi-Software | MediaWiki - small adjustment on the way how latest version is checked.

Co-authored-by: MichaIng <[email protected]>
DietPi-Software | MediaWiki - adjust the way fetching current version.

Co-authored-by: MichaIng <[email protected]>
- CI | DietPi-Software: Test webserver, PHP and database when installing MediaWiki
- DietPi-Software | MediaWiki: Do all file writes in tmpfs before moving install to disk, switch to software ID 210 to not remove and readd a software title with the same ID with some release, which makes install state cleanup difficult
@MichaIng MichaIng force-pushed the wiki branch 2 times, most recently from 7e6e180 to 09860fe Compare June 25, 2023 18:22
- DietPi-Software/DietPi-LetsEncrypt | Use shipped Lighttpd setenv module config from Bullseye on where required
- DietPi-Software | MediaWiki: Set nosniff header for uploads to mute warning on Lighttpd and Nginx, set OOTB on Apache
@MichaIng
Copy link
Owner

Works fine. I'll merge this for the beta, will take care of the above ToDo later.

@MichaIng MichaIng merged commit f95f7f6 into dev Jun 25, 2023
@MichaIng MichaIng deleted the wiki branch June 25, 2023 18:35
@MichaIng
Copy link
Owner

Very strange that the LocalSettings.php is not automatically stored to the wiki directory but that one needs to download and upload it manually. The PHP user has write permissions, but probably this is not intended? Write permissions for /cache and /images is definitely needed, probably other sub directories, but likely not the root. Does it have an internal updater?

So another task:

  • Check for and apply minimal required permissions

@Joulinar
Copy link
Collaborator Author

Yeah not sure why they doing it that complicate to create initial configuration file.

@Ernstian
Copy link

Wouldn't it be possible to create a LocalSettings.php during the installation? Most variable settings should be given by the installation script anyway (database stuff, for example)

@Joulinar
Copy link
Collaborator Author

Creating the file is not the challenge but you would need to complete the first run setup process of MediaWiki still, to create database content, users aso. And this config step is starting only, if no LocalSettings.php is present. From our side we don't have any influence into the MediaWiki configuration process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants