Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quartz64 | Enable RAID modules #6370

Merged
merged 2 commits into from
May 10, 2023
Merged

Quartz64 | Enable RAID modules #6370

merged 2 commits into from
May 10, 2023

Conversation

dano6
Copy link
Contributor

@dano6 dano6 commented May 8, 2023

This PR should enable linux software raid modules for Quartz64 devices

@MichaIng
Copy link
Owner

Many thanks for contributing this. Is it intentionally still a draft? If you want to test it, I can quickly build a kernel package with this change.

Btw, I tend to lookup details about configs here: https://www.kernelconfig.io/config_md_linear?arch=arm64

And then I check how it is implemented on RPi and Debian's kernel, just to get an idea how it is commonly done:

root@micha:~# zgrep CONFIG_MD_LINEAR /proc/config.gz
CONFIG_MD_LINEAR=m
root@dietpi:~# grep CONFIG_MD_LINEAR /boot/config-6.1.0-7-amd64
CONFIG_MD_LINEAR=m

Debian sets those settings all as well, on RPi the last 3 are unset (which default to "no" then), but I think it is fine to add them here as modules.

MichaIng
MichaIng previously approved these changes May 10, 2023
@MichaIng MichaIng changed the title Quartz64 | Enable Raid modules Quartz64 | Enable RAID modules May 10, 2023
@dano6
Copy link
Contributor Author

dano6 commented May 10, 2023

Yes, it is a draft, because I wanted to test it. Can you please start build action?
What kernel are using other devices, upstream kernel from debian?

enable raid modules for quartz64
@MichaIng
Copy link
Owner

Ah, I cannot trigger our CI on forks, as they have no access to secrets. Let me merge it. If it does not work, we can patch if afterwards. It does not overwrite the packages currently downloaded on Quartz64 updates and image generations, which needs to be still manually done, so is safe to do.

- CHANGELOG | Quartz64: Enabled (software) RAID and LVM support. Many thanks to @dano6 for implementing this: MichaIng#6370
@MichaIng MichaIng marked this pull request as ready for review May 10, 2023 21:18
@MichaIng MichaIng merged commit 20c04ad into MichaIng:dev May 10, 2023
@MichaIng
Copy link
Owner

Build is running, done in ~45 minutes: https://github.com/MichaIng/DietPi/actions/runs/4941429029
Packages will then appear here: https://dietpi.com/downloads/binaries/testing/

@dano6
Copy link
Contributor Author

dano6 commented May 11, 2023

Thanks for the merge, but for some reason I don't see built packages there.

@MichaIng
Copy link
Owner

I see them here 🤔. However, e.g. for Quartz64 A:

cd /tmp
curl -O 'https://dietpi.com/downloads/binaries/testing/firmware-quartz64a.deb'
dpkg -i firmware-quartz64a.deb
rm firmware-quartz64a.deb

resp. firmware-quartz64b.deb and firmware-soquartz.deb.

disconn3ct added a commit to disconn3ct/DietPi that referenced this pull request May 12, 2023
* upstream/dev:
  v8.18
  v8.18 (MichaIng#6370)
  v8.18
  v8.18 (MichaIng#6371)
  Init v8.18
@dano6
Copy link
Contributor Author

dano6 commented Jun 7, 2023

Thanks, it works fine, i didn't have time to test it earlier.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants