Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DietPi-Software | UrBackup: Fix for obtaining latest version #6355

Merged
merged 1 commit into from
May 1, 2023
Merged

Conversation

Joulinar
Copy link
Collaborator

@Joulinar Joulinar commented May 1, 2023

Correct a typo and bump to latest version. Furthermore, URL https://hndl.urbackup.org/Server/latest seems not to exist anymore.

Reported at our forum https://dietpi.com/forum/t/404-on-trying-to-install-urbackup/16744/2

@Joulinar Joulinar requested a review from MichaIng May 1, 2023 19:01
@Joulinar Joulinar self-assigned this May 1, 2023
@Joulinar Joulinar added this to the v8.17 milestone May 1, 2023
@MichaIng
Copy link
Owner

MichaIng commented May 1, 2023

Dammit, I just implemented https://hndl.urbackup.org/Server/latest, and a month later it is removed 😞: https://hndl.urbackup.org/Server/

DietPi-Software | UrBackup: Update method do obtain latest version, as https://hndl.urbackup.org/Server/latest/ does not exist anymore
@MichaIng MichaIng changed the title DietPi-Software | UrBackup DietPi-Software | UrBackup: Fix for obtaining latest version May 1, 2023
@MichaIng
Copy link
Owner

MichaIng commented May 1, 2023

So, the latest version string/dir is now obtained first, and an arch matching download as second step. Uses a little hardened grep match to assure we match only links.

@MichaIng
Copy link
Owner

MichaIng commented May 1, 2023

What a perfect use case for our new test workflow: https://github.com/MichaIng/DietPi/actions/runs/4855249837

@MichaIng MichaIng merged commit f31ada0 into dev May 1, 2023
@MichaIng MichaIng deleted the urbackup branch May 1, 2023 21:59
disconn3ct added a commit to disconn3ct/DietPi that referenced this pull request May 3, 2023
* dev: (75 commits)
  v8.17 (MichaIng#6362)
  v8.17
  v8.17 (MichaIng#6328)
  v8.17
  v8.17 (MichaIng#6356)
  v8.17
  v8.17
  v8.17
  v8.17
  v8.17 (MichaIng#6355)
  v8.17
  v8.17
  v8.17 (MichaIng#6353)
  v8.17
  v8.17
  v8.17
  v8.17 (MichaIng#6339)
  v8.17 (MichaIng#6303)
  v8.17
  v8.17
  ...
@MichaIng
Copy link
Owner

MichaIng commented Jun 3, 2023

Lol, the latest/ directory has been added again: https://hndl.urbackup.org/Server/latest/
However, now we'll stay with the new method.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants