Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dietpi software] added homer via nginx #5829

Closed
wants to merge 0 commits into from
Closed

Conversation

t3dium
Copy link

@t3dium t3dium commented Oct 24, 2022

also made a PR for homer's documentation 784

sudo unzip homer.zip -d /mnt/dietpi_userdata/Homer/
sudo cp /usr/share/nginx/homer/assets/config.yml.dist /mnt/dietpi_userdata/Homer/assets/config.yml

#create nginx config - echo line by line to conf
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you planning to add Apache as well as Lighttpd? Because we offer all 3 web server stacks.

Copy link
Author

@t3dium t3dium Oct 24, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i've mainly only used nginx in the past, not too familar with apache and lighttpd. I'll look into them tho

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

time to discover new things 😜

Comment on lines 977 to 978
aSOFTWARE_DOCS[$software_id]='https://github.com/bastienwirtz/homer'
#------------------
Copy link
Collaborator

@Joulinar Joulinar Oct 24, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You would need to add web server dependency like

Suggested change
aSOFTWARE_DOCS[$software_id]='https://github.com/bastienwirtz/homer'
#------------------
aSOFTWARE_DOCS[$software_id]='https://dietpi.com/docs/software/system_stats/#homer'
aSOFTWARE_DEPS[$software_id]='webserver'
#------------------

Does it require anything like PHP?

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope, it is all a static page. Sadly currently webservers are pulling PHP as dependency 🤔. I wanted to de-tangle this anyway, can do this after this PR has been merged.

@Joulinar
Copy link
Collaborator

Best would be if you check how other software installs are done and use our install DietPi functions inside the software script 😉

@MichaIng MichaIng added this to the v8.11 milestone Oct 24, 2022
@Joulinar
Copy link
Collaborator

this commit seems to cause issues again cd4c4a9

@MichaIng
Copy link
Owner

But also the back and forth with the master branch now causes a forceful revert of all current changes in dev. I hope we can undo and squash those commits 😅.

@Joulinar
Copy link
Collaborator

unfortunately I hit the wrong button on GitHub desktop app 😢

@MichaIng
Copy link
Owner

MichaIng commented Oct 25, 2022

Dammit, trying to repair it, I undid everything. And now I have no permissions (since PR is closed) to undo 🙈.

@t3dium
Please do not pull your origin, so your local changes are not lost. But it was anyway not possible to review the PR. It is essential that you prevent your editor from doing all the tab<>space changes, but keep and follow the tab format that is in the file.

@MichaIng
Copy link
Owner

Recovered it here: #5833
Looks actually good, no indentation changes, did I miss something?

MichaIng added a commit that referenced this pull request Oct 25, 2022
- DietPi-Software | Homer: Apply suggestions from #5829
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants