-
-
Notifications
You must be signed in to change notification settings - Fork 504
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[dietpi software] added homer via nginx #5829
Conversation
dietpi/dietpi-software
Outdated
sudo unzip homer.zip -d /mnt/dietpi_userdata/Homer/ | ||
sudo cp /usr/share/nginx/homer/assets/config.yml.dist /mnt/dietpi_userdata/Homer/assets/config.yml | ||
|
||
#create nginx config - echo line by line to conf |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you planning to add Apache
as well as Lighttpd
? Because we offer all 3 web server stacks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i've mainly only used nginx in the past, not too familar with apache and lighttpd. I'll look into them tho
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
time to discover new things 😜
dietpi/dietpi-software
Outdated
aSOFTWARE_DOCS[$software_id]='https://github.com/bastienwirtz/homer' | ||
#------------------ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You would need to add web server dependency like
aSOFTWARE_DOCS[$software_id]='https://github.com/bastienwirtz/homer' | |
#------------------ | |
aSOFTWARE_DOCS[$software_id]='https://dietpi.com/docs/software/system_stats/#homer' | |
aSOFTWARE_DEPS[$software_id]='webserver' | |
#------------------ |
Does it require anything like PHP?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nope, it is all a static page. Sadly currently webservers are pulling PHP as dependency 🤔. I wanted to de-tangle this anyway, can do this after this PR has been merged.
Best would be if you check how other software installs are done and use our install DietPi functions inside the software script 😉 |
this commit seems to cause issues again cd4c4a9 |
But also the back and forth with the master branch now causes a forceful revert of all current changes in dev. I hope we can undo and squash those commits 😅. |
unfortunately I hit the wrong button on GitHub desktop app 😢 |
Dammit, trying to repair it, I undid everything. And now I have no permissions (since PR is closed) to undo 🙈. @t3dium |
Recovered it here: #5833 |
also made a PR for homer's documentation 784