-
-
Notifications
You must be signed in to change notification settings - Fork 503
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DietPi-Software | Jellyfin #5559
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Check out the Create_Config
function, which does basically the same: Loop and wait for config file with timeout 🙂.
That's as it is right now. And there is the problem atm. Because the service needs to finish his startup once, to be able to create configuration files on next service start. Currently we stop the service right after package has been installed. And that's to early. There the service did not complete and will not create files next service start, which ist triggered by I hope I could explain it a bit. Honestly I'm not sure if this is an intended behaviour. |
Ah nasty. There must be another file we can wait for on first service start, or is or something like a database entry that needs to exist? |
Honestly I don't know. The service needs to pass the first a couple of initial steps. But not sure if he is doing something on file system level. |
There must be some change in filesystem level, as there is nothing else that can be different on service restart. But a specific database entry is difficult to check for. I'll have a look. |
Actually if the config files do not exist yet, why do we stop the service just for starting it again. In this case we can just let it run to safe time and extra restart loop when waiting for the config file to be created. |
Doesn't matter how we do it, we need to keep the service first time running for 20-30 seconds before we are going to restart. |
(Therefore I tried to delay the shutdown of the service right after it has been installed) can u teach how to do this, so just before the arrival of dietpi v8.6? |
Most probably we will release a beta version of DietPi v8.6 on upcoming weekend. I recommend to wait 2 more days. |
- DietPi-Software | Jellyfin: Since a while FFmpeg 6 is available for Jellyfin, but on old installs with the old FFmpeg 5 package, it is not upgraded automatically by APT. This DietPi update applies the FFmpeg upgrade to all affected systems. Many thanks to @gioxx and @WolfganP for reporting this issue: #7080 - DietPi-Software | Jellyfin: Resolved an issue where the intended HTTP port change could not be applied, since the network config file is not created anymore at service start. We do now pre-create a minimal one, which is complemented with defaults automatically. There was a related issue: #5559. However, now, indeed network.xml is never created, intentionally, which is fine, since Jellyfin internally applies defaults for all non-defined settings, and stores them back to the config file when completing the web UI setup or saving network settings in web UI. So we can perfectly pre-create a minimal config with just the settings we need to have changed from defaults. Also XML syntax can be minimal, no XML meta data or schemes needed. No need to wait for config files to be created while setting the service start up.
Jellyfin service needs some time now to finish first time startup. Otherwise config files are not created next time we start the service. https://dietpi.com/forum/t/jellyfin-installation-error/13402
I'm not quite happy with the delay of 30 sec, maybe you have a better idea @MichaIng
Furthermore we need to changed
WorkingDirectory
within service config to point to/mnt/dietpi_userdata/jellyfin
as well.