Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DietPi-Banner | Add option to disable credits #5355

Merged
merged 1 commit into from
Mar 24, 2022
Merged

DietPi-Banner | Add option to disable credits #5355

merged 1 commit into from
Mar 24, 2022

Conversation

math-gout
Copy link
Contributor

The credits part of dietpi-banner takes a lot of space, so I added an option to disable it.
I know that they are important so they are enabled by default.

@MichaIng
Copy link
Owner

Many thanks for your PR.

We intentionally did not add this toggle to always keep honour for all kinds of project contributors. But I understand that it takes a significant part of the login screen and when seen once, it may not be important to force it being shown on every login again. I add the team for reviewing for a decision on this.

@Joulinar
Copy link
Collaborator

@MichaIng
let's have a chat on our next project meeting to discuss about.

@MichaIng
Copy link
Owner

I was just about to edit something into my post, you are too fast 😄. Good idea. However let me still add this:

The only thing that may change is the Patreon Legends, but if we would like to assure that they are given credits among all users, we could also reset the setting on update, if a new Patreon Legend joined, or we can add this to the changelog (I think we did in the past), show an additional prompt as part of the patches or similar, even depending on whether credits are enabled in the banner or not.

@MichaIng MichaIng changed the title Dietpi-Banner | Add option to disable credits DietPi-Banner | Add option to disable credits Mar 21, 2022
@MichaIng MichaIng added this to the v8.3 milestone Mar 24, 2022
@MichaIng MichaIng merged commit 9eaacae into MichaIng:dev Mar 24, 2022
MichaIng added a commit that referenced this pull request Mar 24, 2022
- CHANGELOG | DietPi-Banner: It is not possible to hide the credits section from the DietPi banner. Run "dietpi-banner" to configure its content. Many thanks to @math-gout for contributing this feature: #5355
This was referenced Apr 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants