Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DietPi-Software | qBittorrent: Some fixes and enhancements #4730

Merged
merged 1 commit into from
Sep 12, 2021
Merged

Conversation

MichaIng
Copy link
Owner

@MichaIng MichaIng commented Sep 12, 2021

Status: Testing

Testing:

  • Bullseye
  • Buster
  • Stretch

Commit list/description:

  • DietPi-Software | qBittorrent: Do not apply UNIX user password for "qbittorrent" user anymore, as it is not used
  • DietPi-Software | qBittorrent: Do not grant "dietpi" group write permissions to qBittorrent config and log directories.
  • DietPi-Software | qBittorrent: Reorder and cleanup default config so that it can be better compared to what it looks like after first service start. Remove settings which are empty or unsed (due do disabled states) or where defaults are good.
  • DietPi-Software | qBittorrent: Fix applying default password PBKDF2 hash

+ DietPi-Software | qBittorrent: Do not apply UNIX user password for "qbittorrent" user anymore, as it is not used
+ DietPi-Software | qBittorrent: Do not grant "dietpi" group write permissions to qBittorrent config and log directories.
+ DietPi-Software | qBittorrent: Reorder and cleanup default config so that it can be better compared to what it looks like after first service start. Remove settings which are empty or unsed (due do disabled states) or where defaults are good.
+ DietPi-Software | qBittorrent: Fix applying default password PBKDF2 hash
@MichaIng MichaIng added this to the v7.6 milestone Sep 12, 2021
@MichaIng MichaIng changed the base branch from master to dev September 12, 2021 13:08
@MichaIng
Copy link
Owner Author

I'm a bid confused about whether to keep UPnP usage enabled or not. On the one hand, I don't like it and think it is a security issue to have it enabled in the router and would never encourage users to enable it but to always keep it disabled. On the other hand, when it is enabled, it is comfortable when qBittorrent automatically enables port forwarding for 6881 and 1340 (web interface) 🤔, in case of the web interface of course only when this shall be even reachable remotely.

However, I'll leave it like this for now, but something to discuss and have a consistent setup across software installs.

@MichaIng MichaIng merged commit 961b649 into dev Sep 12, 2021
@MichaIng MichaIng deleted the qbittorrent branch September 12, 2021 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant