DietPi-Software | Refactoring and alignment #4701
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
+ DietPi-Software | Do not use global $INSTALL_URL_ADDRESS and $UNINSTALL_URL_ADDRESS variables anymore, but replace them with local $url. There is not point in having these globally and this is a preparation for placing each install block into its own function, having all related variables local ones to rule out interference. + DietPi-Software | Update all fallback URLs/versions when auto-detection of latest version via GitHub API is done + DietPi-Software | Skip G_CHECK_URL when the download is done without any larger prior steps + DietPi-Software | Install all 3rd party APT keys as dedicated files and don't use the deprecated apt-key anymore at all + DietPi-Software | Apply G_EXEC error-handling in some more cases + DietPi-Software | Minor coding, reodering and wording
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status: Testing
Commit list/description: