-
-
Notifications
You must be signed in to change notification settings - Fork 502
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Beta v7.0.1 #4146
Beta v7.0.1 #4146
Conversation
+ DietPi-Pre-patches | Update Jellyfin APT repo key, if last modified prior to expiration date: https://dietpi.com/phpbb/viewtopic.php?t=8703
+ DietPi-Drive_Manager | The "_netdev" mount option is not required for CIFS and Samba mounts, since systemd identifies them automatically as remote/network mounts. This option is only required when the remote/network mount cannot be identified by its file system type: http://codingberg.com/linux/systemd_when_to_use_netdev_mount_option + DietPi-Drive_Manager | Minor coding
+ DietPi-Software | Really fix Download_Install: If no target path is given, but file type is an achieve, it has been extracted/installed and hence needs to be removed. Else, if either no target path has been given or it matches the downloaded file name, return the function so that we don't need to complicated logic afterwards whether the file needs to be removed or not. Luckily the optional environment variables can be unset before starting to unpack/install/move the downloaded file.
The choice of the user for an automatic logic (with its dialog) appeared too often. Now the choice is only done in cases of automatic login (dietpi-autologin options 7 and 2).
+ DietPi-Software | Do not offer to install and configure No-IP from within the software selection. It will fail as of concurrent dietpi-software execution. Since this was the only reason for writing/reading a temporary install state file, this function can be removed from the code. Instead allow to configure No-IP after it has been installed. + DietPi-Software | Offer to configure DietPi-AutoStart after installs instead of before installs. We'd need to allow failing systemctl calls and others to allow this, and need to keep re-configuring DietPi-AutoStart (automated) after installs. It's better do have the ability to for error handling all required steps and hence relying on software services and binaries being available so that we can check and assure that all worked fine. Since DietPi-Software does not force a reboot after installs, this interactive step after installs have finished is pretty fine and it adds to the anyway possible GPU memory split prompt + No-IP config with above change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I checked the changed behaviour of the dietpi-autostart (also called within dietpi-software). This works fine.
Also the change that the login selection is done after all installations is a better choice. Love that.
All other issues I have not reviewed. So no global approve is possible.
Many thanks for testing those it. The merge yesterday night was an accident when I wanted to resolve branch conflicts 😅, so that PR deserved a dedicated review. |
+ DietPi-Software | Add way to automatically restore from backup on first boot + DietPi-Software | Only reboot when backup restore succeeded, inform user about it for three seconds + DietPi-Software | Downgrade auto-restore =2 to =1 in every case + DietPi-Backup | Clear PATH cache after backup restore, in case commands are restored to a different locations + DietPi-Backup | Do not stop services before we definitely run the backup or restore. The rsync process check still needs to be done after stopping the services, which include the rsync daemon. But do not kill a running rsync process afterwards, better error out. + DietPi-Backup | Implement function when restoring a backup, to check whether the backup's UUIDs match the current drive's UUIDs, so that we do not restore a system that is not booting, because the bootloader and fstab do not find the configured drives. If the UUIDs seem to not match, check whether we are able to reliably make the system bootable by adjusting known bootloader configurations. Add function to restore UUIDs, in case, but content is on ToDo for now :). + DietPi-Globals | G_WHIP_YESNO: If the default is set to "yes", return "true" as well in case of non-interactive calls + DietPi-Backup | Add whiptail yes/no dialogues when storing a backup to a system with different UUIDs. Default to "yes", if we did find the boot configuration method, else default to "no", which is especially relevant for non-interactive first run setups with AUTO_SETUP_BACKUP_RESTORE=1 set.
+ DietPi-Software | SABnzbd: Since v3.2.0 raised the minimum Python dependency to v3.6, on Stretch, v3.1.1 needs to be installed. However, check the actually installed Python version so that a custom Python install allows to install SABnzbd v3.2+ as well. + DietPi-Software | SABnzbd: Use the new Create_Config function to pre-create the config file
@MichaIng
As well it seems |
I have no idea how after The problem with I collected some thoughts here: #2558 |
ok understood. As said, the system is working fine after restore. Good to go for this release. Next I tested SABnzbd on Stretch. Python 3.5 as well as SABnzbd 3.1.1 are installed and working. |
Beta v7.0.1
(2021-02-27)
Changes since v7.0.0
Fixes since v7.0.0