Update "update" branch #4107
Merged
Update "update" branch #4107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
+ DietPi-Software | Fix download GitHub URL/version detection for ruTorrent, Koel and Bitwarden_RS: mawk does not support "[[:blank:]]" syntax, hence the fallback URL was used in those cases. + DietPi-Software | Align automated GitHub download URL/version detection for all installs. Take into account that mawk is not able to handle "[[:blank:]]" syntax and variables, hence if this is required, "grep | cut" pipe needs to be used. Use "curl -sSfL" in all cases so that curl errors and server error responses are shown, for debugging purpose. mawk and grep are then not allowed to exit on first match, since this causes a curl 23 exit code and error message about a broken pipe before the response could have been written completely, when the match was not within the last buffer chunk. To compensate this, assure that a single match exists by being more specific about the expected regex, assure that a fallback is present and effective in every case. **Once Stretch support is dropped, we could use `CURLOPT_BUFFERSIZE=524288` (introduced with curl v7.53 vs Stretch curl v7.52.1) to maximise the curl buffer chunks so that a GitHub API page fully fits inside and parsing can stop at first match. But being explicit about the URL has it's own benefits, in case of multiple matches we might want to review the two options and pick one explicitly.** + DietPi-Software | Whenever a download fallback URL or version string is used, print an error message, inform about the fallback but ask user to do a report as obviously we need to update the URL or regex. + DietPi-Software | "curl -IL" does not suffer from failing GitHub download URL checks, hence the workaround to check the API page only can be removed. Testet on all distros from Stretch to Bullseye. + DietPi-Software | Use G_EXEC more widely throughout the script, where applicable
MichaIng
added
the
META
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.