DietPi-CloudShell | Fix and simplify obtaining Pi-hole stats #4100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
+ DietPi-CloudShell | Fix and simplify obtaining Pi-hole stats, by asking FTL via it's TCP port API directly, instead of querying any logs or database files manually. This matches the method how Pi-hole's Chronometer and PADD are doing it: https://github.com/pi-hole/pi-hole/blob/development/advanced/Scripts/chronometer.sh, https://docs.pi-hole.net/ftldns/telnet-api/ + DietPi-CloudShell | Massively simplify uptime estimation: Instead of looping through each minute, then each hour, then each day, calculate hours and days in a single step + DietPi-CloudShell | When obtaining drive data hangs, do not killall df executions but be more specific by storing the PID and killing the exact process only + DietPi-CloudShell | Do not initialise variables with "0" when they are not aimed to be integers
+ DietPi-CloudShell | Pi-hole scene: /dev/tcp/127.0.0.1/$port does not exist in the file system, but as possible file descriptor only, hence remove the existence check + DietPi-CloudShell | Pi-hole scene: The FTL API allows only one output command per time, hence get last blocked domain first, without closing the connection, then get the other stats and close the connection. + DietPi-CloudShell | Pi-hole scene: Fix syntax to parse one line per loop via read
+ DietPi-CloudShell | Pi-hole scene: Prevent division with zero, when no queries have been processed yet + DietPi-CloudShell | Pi-hole scene: FTL cannot handle a second command when the first commands output has not fully been read. Follow Chronometer/PADD in closing the connection after the first command and re-establishing it before sending the second command. + DietPi-CloudShell | Pi-hole scene: Show function exit code when FTL connection failed, for debugging purpose + DietPi-CloudShell | Pi-hole scene: Fix detection of Pi-hole install by checking for pihole-FTL command
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status: Ready
Commit list/description: