Apply desktop Customisations to all users #4015
Conversation
A couple instances in dietpi-software contained github links to MichaIng/Dietpi, instead of the config specified
|
Ah, as said, I aim to remove the |
|
how about creating a folder with all the default user configs, that get copied, once a autostart-user is selected? |
|
For the configuration files there is probably a local user-wide override directory already, so that nothing needs to be copied. Not sure about the desktop entries. What needs to be considered is that most DietPi scripts require root permissions, so executing them from desktop as non-root fails. That would require own entries with a sudo prefix, or we could skip them to require a root desktop or shell session. |
|
Acidentially deleted the branch. I should really start naming my pr branches! |
+ DietPi-Software | Desktop shortcuts are now created as follows: On first desktop install, a system-wide desktop autostart entry is created that links/copies user-level configs and desktop entries into the users home dir, once it logs in the first time. The autostart entry then disables itseld. This way only users which are actually used for desktop sessions get related configs and entries, and only a single time. Desktop shortcuts for later installed software titles are added only to users, which did already log into a desktop, hence have the autostart entry disabled. For now users, those are added by the autostart entry as well. + DietPi-Software | Further implement G_EXEC error handler where applicable and minor coding
|
You should probably mark the requested changes as complete/approved. |
|
"change requested" cannot be undone without approving the PR. But for that I'll now run some tests first 😉. |
+ DietPi-Software | DietPi-Desktop_setup: Add htop to default desktop shortcuts + DietPi-Software | DietPi-Desktop_setup: Fix root user detection + DietPi-Software | DietPi-Desktop_setup: Pre-create autostart directory before writing to it + DietPi-Software | LXDE: Fix lxpanel default config directory and apply pcmanfm desktop item config manually within DietPi-Desktop_setup: The default desktop-items-0.conf for users cannot be overwritten by placing a file in any system directory, the content seems to be hardcoded and needs to be altered after it has been created. Since only the wallpaper and fonts shadow colour are relevant changes we apply, this is not a big issue.
+ DietPi-Software | DietPi-Desktop_setup: Replace /root in bookmarks with actual users home + DietPi-Software | DietPi-Desktop_setup: Use desktop entry version 1.0, since MATE does not accept newest version 1.5 + DietPi-Software | MATE: Enable audio (playback and settings panel) by installing the mate-media package + DietPi-Software | MATE: Skip xcompmgr install with MATE, since MATE has one integrated which blocks xcompmgr start + DietPi-Software | MATE: Do not add a Caja desktop icon, since by default a user home icon is present already
+ DietPi-Software | Desktops: Simplify xcompmgr install, which is only used/compatible with LXDE and LXQt. All other desktops have one integrated so that either the integrated one or xcompmgr fails. To be failsafe on Xfce, actively remove the autostart entry as it breaks the internal one, leading to ugly results. + DietPi-Software | X server: Do not install xterm by default. Each desktop has an own terminal emulator which looks and works much better. Especially when starting terminal applications from desktop entries, xterm overrides the desktops emulator, but has limited colour and fonts set, which does not look good. If there is a non-desktop X application that can make use of a terminal emulator without shipping one, we can re-add it to the related X client install.
Status: Testing
Also please link the issues below.
Reference: fixes #4014 fixes #3994