Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v6.30 #3526

Merged
merged 19 commits into from
May 10, 2020
Merged

Release v6.30 #3526

merged 19 commits into from
May 10, 2020

Conversation

MichaIng
Copy link
Owner

v6.30

(10/05/30 Hotfix)

Changes / Improvements / Optimisations

Bug Fixes

MichaIng added 17 commits May 4, 2020 11:34
+ System | Grant all users permissions to write to DietPi runtime directory, especially for writing the MOTD via banner
+ DietPi-Banner | In case corrupt MOTD, i.e. sourcing fails or the string is not set as it should be, only attempt to remove it if the current user has write permissions. This should not have any practical relevance since the user who downloaded it initially should run into the failure and remove it already, but let's be failsafe to minimise the risk for ugly error messages in banner.
+ DietPi-Boot | Replace wrong chown with wanted chmod
+ DietPi-PREP | Re-add RPi as default for device selection, to not start at the bottom, but at the top of the list: #1285 (comment)
+ DietPi-Globals | Do not auto-generate a missing .hw_model. This is done at boot and on every update, hence it is always present. If it is really missing, it is better to have related error prompts, so the reason for it's absence can be investigated. This re-enables DietPi-PREP to pass custom G_DISTRO* values to have a correct sources.list created even on distro upgrade: #1285 (comment)
+ DietPi-Obtain_HW_model | Fix RPi onboard WiFi detection: #3510
+ DietPi-Drive_Manager | Fix RPi rootfs detection since findmnt does not print anything with /dev/root (df output)
+ DietPi-Patch | Fix patch which should remove scripts from old /boot/dietpi/ location only, but removed them from new /boot/dietpi/func/ location instead: #3509
+ DietPi-PREP | Do not create /etc/.dietpi_hw_model_identifier before it is required the first time and do not create it on RPi, so DietPi-Obtain_HW_model is able to detect the RPi correctly
+ DietPi-Software | qBittorrent: Apply UMask 002 via systemd unit to allow Sonarr/Radarr/Lidarr/.., removing or hardlinking downloads after import: #3524
+ DietPi-Patch | RPi: Fix missing root mount in fstab: #3511
+ CHANGELOG | Add v6.30 changes
+ DietPi-Patch | Assure that Fourdee Git owner is migrated to MichaIng in all cases
+ DietPi-Patch | As well migrate newly supported devices from beta to master branch. During beta phase they have been migrated from dev to beta, so this is to cover beta testers.
+ RC up
+ DietPi-Globals | Default RC up
@MichaIng MichaIng added this to the v6.30 milestone May 10, 2020
MichaIng added 2 commits May 10, 2020 20:38
+ CHANGELOG | Update v6.30 PR link
+ CHANGELOG | Update v6.30 PR link
@MichaIng MichaIng requested a review from Joulinar May 10, 2020 18:46
@MichaIng
Copy link
Owner Author

@Joulinar
Anything urgent I forgot?

@Joulinar
Copy link
Collaborator

Joulinar commented May 10, 2020

Within the forum we have some message that sonarr and radarr have issues after the update. Not sure what is the cause. All have different symptoms.

https://dietpi.com/phpbb/viewtopic.php?f=11&t=7598

But more important to have Drive Manager fixed as well as the missing files

@MichaIng
Copy link
Owner Author

MichaIng commented May 10, 2020

@Joulinar
I had a look into it. Indeed doesn't look like an obvious bug our side, especially since the DietPi update does not touch existing Sonarr/Radarr/Lidarr/Jackett instances and the errors are so very different. Probably it is/was a faulty mono version. Sometimes the many APT package updates and/or service restarts trigger errors that have nothing to do with the actual update but e.g. a faulty APT package or existing disk corruption that becomes apparent due to physically moved data, server restart or such. So I'll not defer v6.30 until tomorrow, but we'll keep investigating those issues of course 👍.

@Joulinar
Copy link
Collaborator

@MichaIng
yap I assume the same. Possibly due to apt or the triggert restart some issue came into the picture that are unknown before.

I know it's wrong place but maybe we can think on some apt update/upgrade and do a restart, before going to implement new DietPi Release. But honestly I even have no idea how to implement in theory, because users would need to be involved actively and test their application after apt and right before DietPi update. I guess it would be way to complicated and far away from DietPi philosophy to take a lot of load from users and automate as much as possible. 🤔

@MichaIng
Copy link
Owner Author

@Joulinar
There is an open request, planned for next release, to do daily automated APT upgrades via dietpi-update, optionally of course.
So one can do update checks only, or automated APT update && upgrade afterwards. This basically is a lightweight replacement for unattended-upgrades which for our end does not randomly block APT.
I think many users do not regularly upgrade their APT packages, and then the DietPi update contains a high amount of them, raising the risk that something does not end smoothly. This feature would keep the amount of upgraded packages per session low, and if any issue appears it can quickly be associated with the last daily APT upgrades.

@Joulinar
Copy link
Collaborator

@MichaIng
probably it can be combined with automatic restarts? Just to have it activated as well. Maybe the user can select a time window. Not sure if this is wise idea. 🤔

@PeterLacknase
Copy link

I don't know you in person and i don't know your goals. But as a BSD-guy and on the Linux side rather a "veteran" i'd highly urge you to stay away from too much "automatism". systemd is annoying enough. :-)

Automated daily updates are possibly ok for desktops. (And even there ... if somebody writes his scientific thesis or has to finish some business papers it's better to have a "potentially missing feature" or a "not that annoying bug" than an "up to date incompatibility".)

It's better imho to just check if apt updates are required before dist-upgrade. If so, stop the process. Give a warning/recommendation to update packages via apt by hand. If something breaks it won't break the dist-upgrade (and leave an even bigger mess behind).

Just my 2 cents.

@MichaIng
Copy link
Owner Author

MichaIng commented May 10, 2020

@Joulinar
The daily update (check) is done as cron job, where time can be chosen via dietpi-cron. Generally APT upgrades are designed a way that a system restart is not required. For this reason also DietPi updates do not force a restart anymore. However of course for testing (before release) restart must be part of the schedule.

@PeterLacknase
Of course this will be an optional feature (disabled by default), for systems and users where some service/process downtime is not a big issue. The DietPi update does and will always include an APT upgrade as first step. This is the only way to assure that our scripts can use external commands and e.g. parse output reliably, when all systems are brought onto the same APT stage. apt-get dist-upgrade is btw not included and we will never do this aside from first boot of a fresh image. It is simply too risky and should only be done with full user attention since it can remove conflicting packages.
E.g. on Raspbian testing suite I regularly run into situations where PHP, MariaDB, the webserver or once even important system core packages would have been removed by a dist-upgrade since a package was updated in the repo but not all packages that are either dependencies or dependants of it. Raspbian repo maintainers do not pay much attention on testing suite repo consistency compared to Debian.

@MichaIng MichaIng merged commit d29a5af into master May 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment