DietPi-Drive_Manager | Fix handling mount sources and targets with spaces #3497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
+ DietPi-Drive_Manager | findmnt also prints multiple matches in case of bind mounts, hence use only first match for mount target and use this mount target (which is unique) to get SIZE, USED and USE%. ToDo: Probably we should simply skip df "-a" option which excludes pseudo file systems like bind mounts. As long as all known network file systems are still shown, it is fine, since we want to exclude everything else anyway.
+ DietPi-Drive_Manager | Fix menu categories for network drives, if those contain spaces, double quote aDRIVE_SOURCE_DEVICE as well in all cases, mainly to handle network shares drives correctly where aDRIVE_SOURCE_DEVICE == aDRIVE_MOUNT_SOURCE. Handle network drives as well explicitly in Return_Drive_Without_Partitions function.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://dietpi.com/phpbb/viewtopic.php?f=11&t=7518