Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Images | Add support for NanoPi NEO Plus2 with new hardware ID 57 #3483

Merged
merged 4 commits into from
Apr 21, 2020

Conversation

MichaIng
Copy link
Owner

@MichaIng MichaIng commented Apr 21, 2020

Status: Ready

Reference: #2979 (comment)

Commit list/description:

  • DietPi-Obtain_HW_model | Add support for NanoPi NEO Plus2 with new hardware ID 57
  • DietPi-Obtain_HW_model | Make $G_HW_ONBOARD_WIFI an RPi special as it practically is right now. It can make sense to use this for all SBC models but it does not make sense to keep it for those as long as it never applied or checked within code.
  • DietPi-Obtain_HW_model | Use official SBC naming, case-sensitive. This currently leads to doubled DietPi-Survey report entries, but we should revert to hardware ID based identification anyway, like it is done for the benchmarks + a reset is planned. It is more important that users see the correct and complete SBC name along with the images, then the beauty of our statistics.

+ DietPi-Obtain_HW_model | Add support for NanoPi NEO Plus2 with new hardware ID 57
+ DietPi-Obtain_HW_model | Make $G_HW_ONBOARD_WIFI an RPi special as it practically is right now. It can make sense to use this for all SBC models but it does not make sense to keep it for those as long as it never applied or checked within code.
+ DietPi-Obtain_HW_model | Use official SBC naming, case-sensitive. This currently leads to doubled DietPi-Survey report entries, but we should revert to hardware ID based identification anyway, like it is done for the benchmarks + a reset is planned. It is more important that users see the correct and complete SBC name along with the images, then the beauty of our statistics.
@MichaIng MichaIng added this to the v6.29 milestone Apr 21, 2020
+ DietPi-PREP | Add support for NanoPi NEO Plus2 with new hardware ID 57
+ DietPi-PREP | Use official SBC naming, case-sensitive
+ DietPi-Survey_report | Add support for NanoPi NEO Plus2 with new hardware ID 57
+ DietPi-Survey_report | Use official SBC naming, case-sensitive
+ CHANGELOG | NanoPi NEO Plus2 | Initial hardware identifier (ID: 57) and support for this device has been added to DietPi. Many thanks to @StephanStS for doing this request and creating an image: #2979 (comment)
@MichaIng MichaIng merged commit bb44eea into dev Apr 21, 2020
@MichaIng MichaIng deleted the NEOPlus2 branch April 21, 2020 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant