-
-
Notifications
You must be signed in to change notification settings - Fork 502
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DietPi-LED_control | Major rework #3397
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
+ DietPi-PreBoot | Remove DietPi-LED_control call, since LED triggers are now applied via udev rules + DietPi-PreBoot | Do not use G_THREAD, since DietPi-Set_CPU is the only larger call being done, hence no benefit of concurrency + DietPi-PreBoot | Do not load DietPi-Globals, since checking for RPi is the only left reason, which can be done much simpler + DietPi-PreBoot | Obtain hardware info only if resulting file is missing, and on RPi to allow SDcard swapping. For non-RPi models, the result can only change after DietPi updates, and DietPi-Patch forces a hardware info reload on every execution.
+ DietPi-Obtain_HW_model | In any unexpected hardware identifier case, revert to "Generic Device" (ID: 22) to assure that our scripts cannot do wrong assumptions, e.g. assume RPi because of missing identifier file only (( $G_HW_MODEL < 10 )). + DietPi-Obtain_HW_model | Remove $IMAGE_ADDITIONAL_CREDITS, since this doubles with .prep_info. If no .prep_info is present (very old images), convert old $IMAGE_ADDITIONAL_CREDITS entry via pre-patches instead (ToDo).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status: Review
Commit list/description: