Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DietPi-Software | Skip setting file permissions globally after each install #3040

Merged
merged 33 commits into from
Aug 10, 2019
Merged

DietPi-Software | Skip setting file permissions globally after each install #3040

merged 33 commits into from
Aug 10, 2019

Conversation

MichaIng
Copy link
Owner

@MichaIng MichaIng commented Aug 6, 2019 •
edited
Loading

Status: testing

  • DietPi-Set_software

Fixes: #2641

Commit list/description:

  • DietPi-Software | Skip "/DietPi/dietpi/func/dietpi-set_software setpermissions" to not overwrite user custom permissions and probably other software permission modes that are more secure. Instead apply required permissions directly during individual software config step.
  • DietPi-Software | BaiKal: Handle reinstalls properly, replace the old instance but keep the old database/configs dir. Install and enable required PHP modules explicitly which allows us on long term to keep the default PHP install slim without additional modules installed by default.
  • DietPi-Software | Uninstall enhancements: Disable services before removing units, unmask in case they are not located in /etc, to have any related symlinks removed for cleaner uninstall. Add checks before removing files/dirs/users to avoid error messages.

@MichaIng
v6.26
ec6e5af 
+ DietPi-Software | Skip "/DietPi/dietpi/func/dietpi-set_software setpermissions" to not overwrite user custom permissions and probably other software permission modes that are more secure. Instead apply required permissions directly during individual software config step.
+ DietPi-Software | BaiKal: Handle reinstalls properly, replace the old instance but keep the old database/configs dir. Install and enable required PHP modules explicitly which allows us on long term to keep the default PHP install slim without additional modules installed by default.
+ DietPi-Software | Uninstall enhancements: Disable services before removing units, unmask in case they are not located in /etc, to have any related symlinks removed for cleaner uninstall. Add checks before removing files/dirs/users to avoid error messages.
@MichaIng MichaIng added this to the v6.26 milestone Aug 6, 2019
@MichaIng MichaIng self-assigned this Aug 6, 2019
@MichaIng MichaIng mentioned this pull request Aug 6, 2019
Closed
MichaIng added 24 commits August 6, 2019 20:02
@MichaIng
v6.26
a64cff2 
+ DietPi-Software | Remove setpermissions call since those are now applied within per-software config steps
@MichaIng
v6.26
c5eebc3 
+ DietPi-Software | MariaDB: In case of /var/lib/mysql symlink, the target dir needs to exist already. Permissions are applied by APT install automatically.
@MichaIng
v6.26
ec819ca 
+ DietPi-Software | Lighttpd: Update perl comment according to quick test and changelog check
@MichaIng
v6.26
89909e1 
+ DietPi-Set_userdata | Skip re-setting permissions. Correct permissions are assured by "G_CHECK_FS_PERMISSION_SUPPORT" and "cp -a" and we should not overwrite any custom permissions set by either user or program installs.
@MichaIng
v6.26
b71bfb5 
+ DietPi-Patch | Apply encrypted PW file permissions only, instead of calling deprecated setpermissions command
@MichaIng
v6.26
e228b45 
+ DietPi-Set_software | Remove setpermissions function. Those are now applied on install for software titles individually. Aside from that we should never overwrite the whole userdata permissions which breaks user custom changes and implies possible security issues in some software cases.
@MichaIng
v6.26
ad346d8 
+ DietPi-WiFi-Monitor | Spelling
@MichaIng
v6.26
43f4d09 
+ DietPi-Justboom | Remove doubled newline
@MichaIng
v6.26
84ef3c2 
+ DietPi-LED_control | Remove doubled newline
@MichaIng
v6.26
91ccb1e 
+ DietPi-Benchmark | Remove doubled newline
@MichaIng
v6.26
2c72c34 
+ DietPi-Morsecode | Remove doubled newline
@MichaIng
v6.26
4396fc2 
+ DietPi-Cloudshell | Remove doubled newlines
@MichaIng
v6.26
8216876 
+ DietPi-Software | HAProxy: Remove doubled newlines in service file
@MichaIng
v6.26
ba1f7d3 
+ DietPi-Software | ProFTPd: Remove doubled newline in config file
@MichaIng
v6.26
b931b45 
+ DietPi-Software | LXDE: Remove doubled newline in OpenBox config file
@MichaIng
v6.26
524b7df 
+ DietPi-Software | CAVA: Remove doubled newlines, trailing spaces and do some spelling corrections in config file
@MichaIng
v6.26
79d7439 
+ DietPi-Login | dietpi.bash: Remove trailing space
@MichaIng
v6.26
409d5e8 
+ DietPi-Pre-patch | Remove trailing space
@MichaIng
v6.26
20035f8 
+ DietPi-Globals | Remove trailing space
@MichaIng
v6.26
cd6db6b 
+ DietPi-Sync | Remove trailing newline
@MichaIng
v6.26
d7ef2bb 
+ DietPi-Software | Remove trailing space and doubled newline
@MichaIng
v6.26
0f16cd9 
+ DietPi-Services | Remove trailing spaces
@MichaIng
v6.26
9addabc 
+ DietPi-Drive_Manager | Remove trailing spaces
@MichaIng
v6.26
a4e3135 
+ DietPi-Autostart | Remove trailing space
MichaIng added 8 commits August 8, 2019 17:02
@MichaIng
v6.26
a91b278 
+ config.txt | Remove trailing space
@MichaIng
v6.26
da65e75 
+ dietpi.txt | Remove trailing space
@MichaIng
v6.26
9b256b4 
+ DietPi-PREP | Remove trailing space
@MichaIng
v6.26
2a4c49c 
+ CHANGELOG | DietPi scripts, i.e. dietpi-software, will not overwrite you custom permissions in /mnt/dietpi_userdata anymore
@MichaIng
v6.26
76b2abe 
+ DietPi-Software | Failsafe "cp -a source/. target/" syntax to assure target is never created as file
@MichaIng
v6.26
50bab58 
+ DietPi-Software | Always use "cp -a" instead of "cp -R" to preserve permissions
@MichaIng
v6.26
b52d64f 
+ DietPi-Software | chown user content dirs (but not contained data) on installs, so media and download software titles have file list and creation permissions.
@MichaIng
v6.26
fffb99f 
+ DietPi-Software | Shorten array names: aSOFTWARE_WHIP_NAME => aSOFTWARE_NAME and aSOFTWARE_WHIP_DESC => aSOFTWARE_DESC
+ DietPi-Software | When looping through all existing software titles, loop through aSOFTWARE_NAME, as aSOFTWARE_INSTALL_STATE can have an old saved value from .installed even if the software title has been dropped from DietPi-Software.
@MichaIng MichaIng merged commit 2534866 into dev Aug 10, 2019
@MichaIng MichaIng deleted the permissions branch August 10, 2019 15:21
@MichaIng MichaIng mentioned this pull request Oct 24, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@MichaIng MichaIng

Labels
Enhancement 💨 Security 🔒
Projects
None yet
Milestone
v6.26
Development

Successfully merging this pull request may close these issues.
1 participant
@MichaIng