Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Beta v6.25.1 #2940

Merged
merged 41 commits into from
Jun 29, 2019
Merged

Beta v6.25.1 #2940

merged 41 commits into from
Jun 29, 2019

Conversation

MichaIng
Copy link
Owner

@MichaIng MichaIng commented Jun 29, 2019

Beta v6.25.1

(29/06/19)

Changes / Improvements / Optimisations (since v6.25.0)

  • System | By default the "haveged" entropy daemon is now installed on all DietPi systems and patched with v6.25. It assures the pool of random bits /dev/random stays filled by using additional sources of randomness. This solves a bunch of issues, including hanging or very long boot times, very long service (re)starts or timeout failures and on Buster hanging network access. Especially affected is PHP7.3-FPM but as well VPN servers and WiFi hotspots and potentially many other network or cryptography related tasks. More information on this topic: System | Service start/boot timeouts due to low "entropy" #2806
  • System | Initial RPi4 support has been added to the code and some other rare RPi models are now detected correctly by their revision codes. Note that a new Buster-based image is required to support RPi4 and further work on DietPi-Config to support new RPi4 features. Full support is expected with DietPi v6.26, testing images can be found here: Image | Raspberry Pi 4 #2935 (comment)

Bug Fixes (since v6.25.0)

MichaIng and others added 30 commits June 25, 2019 18:50
+ Add drive size to selection menu
+ Verify source image file existence and mount as loop directly
+ Add RootFS menu selection based partition detection
+ Automatically detect GPT partition, check for MBR otherwise, exit if non is matching, to not continue with unknown partition table for now
+ Mount image for edit, before shrinking file system, to have correct minimal size AFTER changes have been applied
+ So all drive manipulation/estimation on loop device
+ Use /root instead of $HOME since the script is forced to run as root user anyway
+ DietPi-PREP | Add usb-storage quirk to disable UAS for some Seagate drive that does not support it
+ DietPi-PREP | Cleanup nouveau blacklist where module option was doubled
+ DietPi-PREP | Be more international by shipping images with UTC timezone by default
+ DietPi-Patch | Add usb-storage quirk to disable UAS for some Seagate drive that does not support it
+ DietPi-Patch | Cleanup nouveau blacklist where module option was doubled
+ CHANGELOG | Resolved an issue where on x86_64 systems a specific Seagate drive, attached via USB, does not spin down on idle
+ DietPi-Set_software | RPi Buster: Do not add Stretch archive.raspberrypi.org repo anymore, since the official images are now based on Buster and the Stretch repo only ships incompatible packages, e.g. Kodi 18, failing because of wrong libnfs version dependency.
+ DietPi-PREP | Finally a new raspi-copies-and-fills package arrived in Buster repo that is compatible with udev/systemd.
+ DietPi-Patch | RPi Buster: Re-apply firmware Buster-only repo, remove Stretch branch, reinstall raspi-copies-and-fills which is now compatible
+ DietPi-Software | Automatically decrypt and re-encrypt global software password on Buster images that were dist-upgraded from Stretch, so that the new pbkdf2 method was not yet applied.
+ CHANGELOG | Resolved an issue on Buster systems that were dist-upgraded manually from Stretch, where DietPi-Software failed to obtain the global software password
+ DietPi-Benchmark | RAM: Check if /tmp is mounted as tmpfs, otherwise skip RAM bench
+ DietPi-Benchmark | RAM: Allow to fill 50% of free RAM to increase accuracy and which should be sufficient to assure that nothing is swapped
+ DietPi-Benchmark | FS: Allow to use up to free space - 50 MiB, always use min/max value in case provided value is outside of range or invalid
+ DietPi-Benchmark | Consequently use MiB and fix calculations where 1000 was used
+ DietPi-Benchmark | Consequently quote input values for G_CHECK_VALIDINT in case they contain free spaces
+ DietPi-Globals | unset $G_WHIP_RETURNED_VALUE only on new G_WHIP_INPUTBOX/MENU/CHECKLIST() calls, so it can be used after other G_WHIP_* calls
+ DietPi-Software | Coding: G_WHIP_CHECKLIST() does not return $G_WHIP_RETURNED_VALUE as array, so no ${G_WHIP_RETURNED_VALUE[@]} loop required
+ DietPi-Software | Failsafe: Always double quote G_CHECK_VALIDINT() $1 argument
+ DietPi-Software | Failsafe: Always localise $i in functions when using it in for loops
+ DietPi-Globals | Coding: Replace "sed -n Xp" with "mawk 'NR==X {print}'" which is ~30% faster
+ DietPi-Globals | G_THREAD Environment cleanup: Do not declare $G_THREAD_COUNT and $G_THREAD_COMMAND variables in session, but on demand + sanity checks within G_THREAD_START(), and, unset after G_THREAD_WAIT().
+ DietPi-Globals | G_THREAD_WAIT() Visual: Use G_DIETPI-NOTIFY -2 processing animation instead of printing new line every second
+ DietPi-Globals | G_THREAD_START() Coding: Instead of double subshell for threads, use command assembly, which initiates (including disown) in ~half time
+ DietPi-Software | Mycroft AI: Move default conf into separate file and add listener sample rate override of 48000
+ DietPi-Software | Mycroft AI: Install new separate mycroft.conf
+ DietPi-Software | Fix Help! menu showing doubled software name instead of description
+ DietPi-Software | Failsafe and consistency coding
+ DietPi-Config | Revert workaround for G_WHIP_MSG() resetting $G_WHIP_RETURNED_VALUE, since this has been reverted: 8d382e6
+ Tiny
+ DietPi-PREP | Install "haveged" entropy daemon by default on all DietPi images: #2806
+ DietPi-Patch | Install "haveged" entropy daemon by default on all DietPi systems: #2806
+ CHANGELOG | By default the "haveged" entropy daemon is now installed on all DietPi system
+ CHANGELOG | Haveged rewording and add Buster network hang issue
+ DietPi-Software | Mycroft AI: Typo
MichaIng added 4 commits June 29, 2019 19:17
+ DietPi-Config | Add RPi4 default sdram_freq based on official docs: https://www.raspberrypi.org/documentation/configuration/config-txt/overclocking.md
+ DietPi-Config | Fix RPi2 default sdram_freq 450 => 400
+ DietPi-Config | Minor coding
+ DietPi-FirstBoot | Add RPi4 default clocks
+ DietPi-FirstBoot | Fix RPi2 default sdram_freq 450 => 400
+ DietPi-FirstBoot | Fix doubled config.txt temp_limit entry
+ DietPi-Patch | RPi3: Remove doubled config.txt temp_limit value
+ DietPi-Patch | Second condition is executed in single arithmetic environment even if first condition is false. => On non-RPi syntax error occurs since config.txt is not available.  => Both conditions need to be checked in individual arithmetic environments.
@MichaIng MichaIng added the Beta 🧪 Issues specific to the Beta branch testing label Jun 29, 2019
@MichaIng MichaIng added this to the v6.25 milestone Jun 29, 2019
@MichaIng MichaIng requested a review from Fourdee June 29, 2019 18:12
MichaIng added 7 commits June 29, 2019 20:31
+ CHANGELOG | RPi4 and further rare RPi detection based on revision codes
+ DietPi-Config | Fix another case where commented config.txt "hdmi_ignore_*=1" entries were interpreted as headless setup
+ DietPi-Config | Minor coding and expect dietpi.txt to be case sensitive while allowing leading spaces
+ DietPi-Set_hardware | Consequently use $FP_RPI_CONFIG (non-RAMdisk support) if we define this already
+ DietPi-Set_hardware | Do not use G_CONFIG_INJECT() to comment settings, as this causes confusing output and adds the comment as well if the setting was not present before
+ DietPi-Set_hardware | Assume dietpi.txt to be case sensitive
+ DietPi-Software | Mycroft AI: Remove doubled G_THREAD_WAIT() and "mkdir -p /etc/mycroft" as Download_Install() creates this dir automatically
+ DietPi-Globals | G_THREAD_START(): ((G_THREAD_COUNT++)) returns false if value is 0, so this cannot be done inside if-then-else one liner
+ DietPi-Software | Mycroft AI: Fix cd into mycroft-core
+ DietPi-Software | Mycroft AI: Grant mycroft user permanent sudo permissions as these are required for some other scripts as well and user might want to update/reinstall/repair via dev_setup.sh
+ DietPi-Patch | Tiny coding consistency
@CollinChaffin
Copy link

For the first time, updating from 6.25.0 to 6.25.1 via dietpi-update brings up the blue update screen with menu, can perform backup and read release notes off that menu, but no matter what I do selecting "Apply 6.25.1 update" even manually tabbing to the OK button and hitting it does nothing at all. I've restarted cleanly and tried again with same result and no other apparent issues on the build. Is there a different way this update needs to be performed?

@user349
Copy link

user349 commented Jul 1, 2019

Try dietpi-update 1
Faced the same issue ,above command updated no problem

@CollinChaffin
Copy link

A bit nervous to do that which is why I commented here first this is unlike past updates before I try to jackhammer it in just wanted to verify if this is a known issue or not but otherwise I guess I'll just force it.

@MichaIng
Copy link
Owner Author

MichaIng commented Jul 1, 2019

@CollinChaffin @user349
Many thanks for reporting. Yes dietpi-update 1 is the way to go.

Found the issue:

root@DietPi:~# whiptail --msgbox 'test' 10 60
root@DietPi:~# whiptail --msgbox '--test' 10 60
--test: unknown option
  • The first works well.
  • The second interprets the message that should show in the box as option (due to leading dashes) which is invalid, thus it fails.

The update whiptail has leading dashes in its text, thus fails. Strange however is that we have this already since... let me see.. ah nope, I removed a leading blank line...

root@DietPi:~# whiptail --msgbox '
> --test' 10 60
  • Works well again.
  • However the leading blank line looked a bid ugly to me 😄.

Resolved with: https://github.com/MichaIng/DietPi/blob/dev/dietpi/dietpi-update

    • some max menu width, so that these dash lines do not end in the middle of the dialog.

Okay this means all current beta users must update with dietpi-update 1 until v6.25.2.


@CollinChaffin
There is btw absolutely no difference between dietpi-update 1 and using the menu, besides that the menu allows you to do backup first, see the changelog and toggle auto-updates. And yeah this confirmation prompt that caused the issue.

@CollinChaffin
Copy link

Wow that was fast! Thanks @MichaIng just ran it non-interactively via dietpi-update 1 and all is well. Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Beta 🧪 Issues specific to the Beta branch testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants