Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

General | Resolve some visual quirks #2907

Merged
merged 3 commits into from
Jun 12, 2019
Merged

General | Resolve some visual quirks #2907

merged 3 commits into from
Jun 12, 2019

Conversation

MichaIng
Copy link
Owner

@MichaIng MichaIng commented Jun 12, 2019 •
edited
Loading

Status: Ready

Reference: #2870

Commit list/description:

  • DietPi-Set_software | Do not use G_CONFIG_INJECT to comment settings as this currently creates misleading output, e.g.: "Comment turned into setting: #..." and adds the commented setting even it if did not exist.
  • DietPi-Software | VNC Server: Only apply config if currently marked for install
  • DietPi-Software | Apply GPU settings only if related software is currently marked for install. Move function call before install mark 2 is applied.

@MichaIng
v6.25
07ae62d 
+ DietPi-Set_software | Do not use G_CONFIG_INJECT to comment settings as this currently creates misleading output, e.g.: "Comment turned into setting: #..." and adds the commented setting even it if did not exist.
@MichaIng MichaIng added Enhancement 💨 Visual 🌹 Issues affecting only the beauty of menus and output, but not the functionality labels Jun 12, 2019
@MichaIng MichaIng added this to the v6.25 milestone Jun 12, 2019
@MichaIng MichaIng self-assigned this Jun 12, 2019
@MichaIng MichaIng mentioned this pull request Jun 12, 2019
Closed
MichaIng added 2 commits June 12, 2019 22:44
@MichaIng
v6.25
f859a1e 
+ DietPi-Software | VNC Server: Only apply config if currently marked for install
+ DietPi-Software | Apply GPU settings only if related software is currently marked for install. Move function call before install mark 2 is applied.
@MichaIng
v6.25
c1e14c5 
+ CHANGELOG | DietPi-Software: Resolved some misleading outputs when having VNC Server or GPU using software installed
@MichaIng MichaIng merged commit b8b199b into dev Jun 12, 2019
@MichaIng MichaIng deleted the visual branch June 12, 2019 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@MichaIng MichaIng

Labels
Enhancement 💨 Visual 🌹 Issues affecting only the beauty of menus and output, but not the functionality
Projects
None yet
Milestone
v6.25
Development

Successfully merging this pull request may close these issues.
1 participant
@MichaIng