Beta v6.23.3

CHANGELOG.txt

@@ -8,11 +8,15 @@ Jessie support:
 - We highly recommend to migrate to Stretch as fast as possible.
 - Odroid C1: We have updated the image to Stretch based on ARMbian 4.18 kernel. Existing Jessie installations will be moved to the jessie-support branch: https://github.com/MichaIng/DietPi/issues/2561
 
+Buster support:
+- DietPi-Software | Resolved the last failing installs on Debian Buster systems by either fixing or disabling them: phpMyAdmin and Tomcat8 are currently not available on non-RPi Buster systems.
+- DietPi on Debian Buster x86_64 systems can be considered as compatible and stable now. On ARM devices some last software install tests are outstanding, especially on Raspberry Pi with Raspbian particularities. We will ship experimental images for testing purpose soon.
+
 Changes / Improvements / Optimisations:
 - DietPi-Banner | Added support for DietPi message of the day (MOTD). This is enabled by default, however, can be disabled. Checks for latest MOTD once a day.
 - DietPi-Banner | Always prints the local IP during boot mode display: https://github.com/MichaIng/DietPi/issues/2681
-- DietPi-Benchmark | Increased default survey RootFS and RAM benchmark sizes. 100MB (from 10MB) for RootFS. RAM is 1/4 of available. This is ensure a more accurate calculation of throughput when we divide bytes against time, to obtain the MB/s result.
-- DietPi-Cleaner | Added a confirmation prompt, before removal of manpages and docs, as this may cause APT issues in some circumstances: 
+- DietPi-Benchmark | Increased default survey RootFS and RAM benchmark sizes. 100MB (from 10MB) for RootFS. RAM is 1/4 of available. This is ensure a more accurate calculation of throughput when we divide bytes against time, to obtain the MB/s result. Benchmarks now also run at Nice -19 and realtime IO with priority 0 (highest).
+- DietPi-Cleaner | Added a confirmation prompt, before removal of offline docs and man pages, as this may cause APT issues in some circumstances. Many thanks to @maartenlangeveld for reporting this issue: https://github.com/MichaIng/DietPi/issues/2751
 - DietPi-LetsEncrypt | When applying to Lighttpd, "webroot" authentication is now used instead of "standalone". This allows the auto-renewal service to succeed while Lighttpd is running. Many thanks to @minnux for testing this method: https://github.com/MichaIng/DietPi/issues/2680#issuecomment-480095449
 - DietPi-Arr_to_RAM | With v6.18 we silently added a new script (for Stretch and above) that allows linking Sonarr/Radarr/Lidarr database files to RAM, increasing access performance, reducing disk I/O and avoiding constant external HDD spinning due to the very regular access to these files. This script has gone through some rework and polishing and can now be enabled to automatically link those databases to RAM on boot and store them back to disk on shutdown. For more details read: https://dietpi.com/phpbb/viewtopic.php?f=8&t=5828. Many thanks to @Dr0bac for providing valuable input and testing the development progress constantly: https://github.com/MichaIng/DietPi/issues/2689
 - DietPi-Drive_Manager | encryptfs and vboxsf (VirtualBox shared folder) fstab entries are now preserved. Many thanks to @johnvick and @Phil1988 for suggesting: https://github.com/MichaIng/DietPi/issues/2078, https://github.com/MichaIng/DietPi/issues/2202
@@ -23,7 +27,7 @@ Changes / Improvements / Optimisations:
 - DietPi-Config | Network Adapter menu has been cleaned up. Proxy variables are now sourced from "/etc/bashrc.d/dietpi-proxy.sh" and proxy setup outside of DietPi scripts is detected.
 - DietPi-NordVPN | Added ability to toggle auto start/connect during boot.
 - DietPi-Software | Subsonic: Package has been updated to v6.1.5. Many thanks to @spectrumcomputing: https://github.com/MichaIng/DietPi/pull/2702
-- DietPi-Software | PHP: All systems will be upgraded to PHP7.3 for security, performance, compatibility and consistency across distro versions. Ondrejs (official Debian PHP maintainer) PHP repository (sury.org) is used for this on Jessie and Stretch, so general functionality and trustworthiness is assured. ownCloud users will stay on PHP7.2 for now since ownCloud does not yet support PHP7.3. Your PHP configurations will be backed up and webserver configurations adjusted to match the new version. Nextcloud 13 and earlier, especially Jessie systems, will be upgraded to Nextcloud 14 to allow PHP7.3. A full Nextcloud backup will be done, your data, settings and custom apps will be preserved. We strongly advice to further upgrade to the current Nextcloud major version via its web UI updater.
+- DietPi-Software | PHP: All systems will be upgraded to PHP7.3 for security, performance, compatibility and consistency across distro versions. Ondrejs (official Debian PHP maintainer) PHP repository (sury.org) is used for this on Jessie and Stretch, so general functionality and trustworthiness is assured. ownCloud and phpBB users will stay on PHP7.2 for where PHP7.3 is not yet supported. Your PHP configurations will be backed up and webserver configurations adjusted to match the new version. Nextcloud 13 and earlier, especially Jessie systems, will be upgraded to Nextcloud 14 to allow PHP7.3. A full Nextcloud backup will be done, your data, settings and custom apps will be preserved. We strongly advice to further upgrade to the current Nextcloud major version via its web UI updater.
 - DietPi-Software | Subsonic: Runs now as limited user "subsonic". This change is as well applied to existing installs via patch during DietPi-Update: https://github.com/MichaIng/DietPi/pull/2705
 - DietPi-Software | WireGuard APT packages are now upgraded when running "apt-get upgrade". Many thanks to @swrobel for reporting this issue: https://github.com/MichaIng/DietPi/issues/2671
 - DietPi-Software | LXQt, GIMP, XFCE4 Power manager: Now available for installations.

dietpi/dietpi-cleaner

@@ -326,7 +326,7 @@ Would you like to continue and start the cleaning process?" && Run_Cleaners
 	Run_Cleaners(){
 
 		# Stop services
-		/DietPi/dietpi/dietpi-services stop
+		(( $DRY_RUN )) || /DietPi/dietpi/dietpi-services stop
 
 		Update_Space_Used
 		ROOT_SPACE_USED_BEFORE=$ROOT_SPACE_USED_CURRENT
@@ -343,16 +343,17 @@ Would you like to continue and start the cleaning process?" && Run_Cleaners
 		ROOT_SPACE_USED_AFTER=$ROOT_SPACE_USED_CURRENT
 
 		# Start services
-		/DietPi/dietpi/dietpi-services start
+		(( $DRY_RUN )) || /DietPi/dietpi/dietpi-services start
 
 		#inform user of space cleared.
 		ROOT_SPACE_FREE_DELTA=$(( $ROOT_SPACE_USED_BEFORE - $ROOT_SPACE_USED_AFTER ))
 
-		if (( $INPUT == 0 )); then
+		if (( $DRY_RUN )); then
 
-			G_WHIP_MSG "$G_PROGRAM_NAME completed."
+			read -p "
+$G_PROGRAM_NAME simulation has finished: Press any key to continue..."
 
-		elif (( $INPUT == 1 )); then
+		else
 
 			G_WHIP_MSG "$G_PROGRAM_NAME has finished cleaning RootFS:\n - $ROOT_SPACE_FREE_DELTA MB of space has been cleared."
 
@@ -366,26 +367,24 @@ Would you like to continue and start the cleaning process?" && Run_Cleaners
 		INFO_CLEAN_NAME='Dev packages'
 		Banner_Cleaning
 
+		# Find packages and convert into 1 line string
 		local string_package_names=''
 		while read line
 		do
 
-			# Convert lined list into a 1 line string.
-			string_package_names+="$line "
-
-		done <<< "$(dpkg --get-selections | mawk '/-dev/ {print $1}')"
+			[[ $line ]] && string_package_names+="$line "
 
-		# Add other dev packages
-		string_package_names+='build-essential git'
+		done <<< "$(dpkg --get-selections *-dev build-essential git make automake autoconf 2> /dev/null | mawk '{print $1}')"
 
-		# Purge
+		# Mark for autoremoval
 		if (( $DRY_RUN )); then
 
-			apt-get -s purge $string_package_names
+			G_DIETPI-NOTIFY 0 "The following dev packages have been found: ${string_package_names:-<none>}"
+			G_DIETPI-NOTIFY 2 "$G_PROGRAM_NAME only purges the ones that are not required for any other installed APT package."
 
 		else
 
-			G_AGP $string_package_names
+			apt-mark auto $string_package_names
 			G_AGA
 			sed -i '/^aSOFTWARE_INSTALL_STATE\[16\]=/c\aSOFTWARE_INSTALL_STATE\[16\]=0' /DietPi/dietpi/.installed &> /dev/null
 			sed -i '/^aSOFTWARE_INSTALL_STATE\[17\]=/c\aSOFTWARE_INSTALL_STATE\[17\]=0' /DietPi/dietpi/.installed &> /dev/null
@@ -400,14 +399,26 @@ Would you like to continue and start the cleaning process?" && Run_Cleaners
 		INFO_CLEAN_NAME='Man pages and docs'
 		Banner_Cleaning
 
-		# Purge
+		# Find packages and convert into 1 line string
+		local string_package_names=''
+		while read line
+		do
+
+			[[ $line ]] && string_package_names+="$line "
+
+		done <<< "$(dpkg --get-selections man-db manpages 2> /dev/null | mawk '{print $1}')"
+
+		# Mark for autoremoval
 		if (( $DRY_RUN )); then
 
-			apt-get -s purge man-db manpages
+			G_DIETPI-NOTIFY 0 "The following man page/docs packages have been found: ${string_package_names:-<none>}"
+			G_DIETPI-NOTIFY 2 "$G_PROGRAM_NAME only purges the ones that are not required for any other installed APT package."
+			G_DIETPI-NOTIFY 2 'Installed man/doc disk usage:'
+			du -sh /usr/share/{man,doc,doc-base} 2> /dev/null
 
 		else
 
-			G_AGP man-db manpages
+			apt-mark auto $string_package_names
 			G_AGA
 			if G_WHIP_YESNO '[WARNING] Removing installed man pages and docs causes errors during "apt-get upgrade" in rare cases (https://github.com/MichaIng/DietPi/issues/2751).\n\nNB: If unsure, please select "Cancel".\n\nDo you wish to continue?'; then