-
-
Notifications
You must be signed in to change notification settings - Fork 501
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DietPi-PREP | Feature/automated build #2756
DietPi-PREP | Feature/automated build #2756
Conversation
+ DietPi-PREP | Consistency: Use G_* naming for all environment variables + DietPi-PREP | Add valid value checks for environment variables, otherwise force interactive prompt + DietPi-PREP | Code alignment according to 8 char tab mode, which is default on our GitHub scripts and most UNIX editors like nano
@FredericGuilbault I added checks to verify the set environment variables have valid values, otherwise it is reverted to interactive input. This is important since otherwise when some typo or invalid value was set, the script runs into very hard to debug errors or even worse: It runs through without any obvious error and the final image will then run into follow-up errors. The last 2 commits you did are included as well. We were coding concurrently here 😉. Testing required:
Just a minor side note:
|
Okay we cannot use G_HW_MODEL, G_GITOWNER etc. |
Okay passed tests with all combinations. I will merge. Changelog: 02e15dc Many thanks again to @FredericGuilbault for adding this 👍. |
Cool, |
@FredericGuilbault |
Status Proof of concept
Add the capability to declare environment variables before script execution to have a non-interactive build. #2745