Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DietPi-Patch | Restart_DietPi_Update() needs to finish BEFORE any reboot can be done #2684

Merged
merged 2 commits into from
Apr 2, 2019

Conversation

MichaIng
Copy link
Owner

@MichaIng MichaIng commented Apr 1, 2019

Status: Ready

Reference: https://dietpi.com/phpbb/viewtopic.php?f=11&t=5752

Commit list/description:

  • DietPi-Patch | Restart_DietPi_Update() needs to finish BEFORE any reboot can be done, otherwise possible new DietPi services (PreBoot, PostBoot) and login scripts (/etc/bashrc.d) are not yet enabled, leading to boot/login issues, missing update finalise etc...
  • DietPi-Patch | Cleanup and merge pre-v6.17 and pre-v6.20 update restarts. Applying testing => dev branch is obsolete since with obsolete testing branch the update fails now at earlier stage (but/and we have no users on testing branch). Running the new update code first allows to skip sync tasks before reboot.

+ DietPi-Patch | Restart_DietPi_Update() needs to finish BEFORE any reboot can be done, otherwise possible new DietPi services and login scripts are not yet enabled, leading to boot/login issues.
+ DietPi-Patch | Cleanup and merge pre-v6.17 and pre-v6.20 update restarts. Applying testing => dev branch is obsolete since with testing branch the update fails now at earlier stage. Running the new update code first allows to skip sync tasks before reboot.
@MichaIng MichaIng added this to the v6.22 milestone Apr 1, 2019
@MichaIng MichaIng self-assigned this Apr 1, 2019
+ DietPi-Patch | Minor
@MichaIng MichaIng merged commit b293ba8 into master Apr 2, 2019
@MichaIng MichaIng deleted the update_fix branch April 2, 2019 19:36
MichaIng added a commit that referenced this pull request Apr 2, 2019
Backwards merge to Beta: #2684
MichaIng added a commit that referenced this pull request Apr 2, 2019
Backwards merge into dev: #2684
@MichaIng MichaIng mentioned this pull request Apr 29, 2019
@MichaIng MichaIng mentioned this pull request May 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant