Beta v6.22.2 #2643

Fourdee · 2019-03-19T15:00:31Z

Beta v6.22.2

(22/03/19)

As always, many smaller code performance and stability improvements, visual and spelling fixes have been done, too much to list all of them here. Check out all code changes of this release on GitHub: https://github.com/MichaIng/DietPi/pulls?q=is%3Aclosed+base%3Amaster

Changes / Improvements / Optimisations (since v6.22.1)

DietPi-Banner | You can now customise which options to display during system login. These include CPU temps, WAN IP, free disk space and more! Simply run 'dietpi-banner': DietPi-Banner | Allow customisation, adding/removing info slots #2627

Known/Outstanding Issues

DietPi-Config | Enabling WiFi + Ethernet adapters, both on different subnets, breaks WiFi connection in some cases: DietPi-Config | WiFi connection fails, when eth + wlan are enabled #2103
DietPi-Config | RPi: Enabling OpenGL/VC4 causes sound card selection to be invalid: DietPi-Config | RPi | OpenGL/VC4 causes soundcard selection to be invalid #2173
DietPi-Drive_Manager | encryptfs is currently not supported and will be removed from fstab when executing drive manager: DietPi-Drive_Manager | Support ecryptfs mounts #2078
RPi | LXAppearance (on LXDE desktop) hangs on dbus-launch: DietPi-Software | TigerVNC+LXDE: Calling lxappearance crashes VNC virtual desktop #1791
Odroid C2 | Some WiFi adapters do no work as hotspot: Odroid | WiFi Adapter 3 Won't Work as HotSpot #1955
Odroid XU4 | Kodi freezes shortly on video playback: DietPi-Software | Kodi: Video playback freezes after few seconds on Odroid XU4 #2584
Rock64 | 3.5mm A/V jack is currently not functional: Rock64 | 3.5mm audio jack not working #2522
DietPi-Software | Node-RED: Pre-installed modules cannot be updated via web UI: DietPi-Software | Node-RED: Pre-installed modules cannot be updated via webUI #2073
DietPi-Software | Raspimjpeg: With Lighttpd, streaming mjpeg does not work: DietPi-Software | Raspimjpeg does not stream mjpeg with Lighttpd #1747

For all additional issues that may appear after release, please see the following link for active tickets: https://github.com/MichaIng/DietPi/issues

#2627 (comment)

+ Improve code to check for forwarding/proxy etc.

+ WIP dietpi-banner changes. NB: need to add back in reobtain IP details if not found at time.

+ Tweaks

+ Minor tweak

+ - DietPi-Banner | You can now customise which options to display during system login. These include CPU temps, WAN IP, free disk space and more! Simply run 'dietpi-banner': #2627 + G_CHECK_FREESPACE (info_autoscale). Switched to MB as thats what G_CHECK_FREESPACE uses, and, throughout DietPi I believe.

+ dietpi-banner hostname option #2627 (comment)

+ Minor ordering

+ Domainname: #2627

beta v2

Fourdee · 2019-03-19T15:01:39Z

@MichaIng

dietpi-banner changes has passed local testing my end. Any chance we can merge this for v6.22 beta testing and release?

+ Weather and uptime: #2627

MichaIng · 2019-03-19T17:47:41Z

@Fourdee
Jep since it's visual only I see no issue in adding this to v6.22 already.

There are two issues that I would like to resolve, but require your help due to lack of devices:

DietPi-Software | Kodi: Video playback freezes after few seconds on Odroid XU4 #2584
If I got it right, you could verify freezing Kodi on your XU4 as well, regardless of using the default xorg.conf from the Odroid repo package? If we cannot resolve this currently, I think we need to forward to Meveric and add this to known issues for now.
Rock64 | 3.5mm audio jack not working #2522
On Rock64 it looks like we need to enable overlays now for certain features like I2C, I2s, general 3.5mm jack output and such. Found the related steps from the armbian-config script (which we remove during DietPi-PREP), but needs testing if indeed the overlay files are at desired location, as on raw image (inspect via 7zip on Windows) this is not the case.

+ myip.php | Minor alignment and wording

+ DietPi-Banner | Function reorder and minor coding

+ DietPi-Globals | G_CHECK_VALIDINT(): Failsafe: Assure $disable_error is either 1 or 0 and that "unset disable_error" always affects the non-local variable if this was set to 1 + DietPi-Globals | G_CHECK_FREESPACE(): Fix MiB => GiB conversion (*1024) and minor coding

+ DietPi-Banner | Further code simplifications and consistency

MichaIng · 2019-03-20T16:53:55Z

@Fourdee
Sorry for coding so much around your banner commit 😅. I was not happy with the inconstancy between aENABLED/DESCRIPTION and aOBTAIN arrays and first wanted to add all options to the aOBTAIN array with identical indices. Sadly $($var) does not support any kind of redirection or piping and even has issues with single quotes that I was not able to resolve. I guess this was also the reason why you left the affected obtain commands outside the array. As I still didn't like the non-matching array indices, I now removed aOBTAIN completely, which simplifies the script a bid.

Only reliable solution I found with array usage is to write the commands to a file and source/execute it back. But that's way too complicated IMO.

+ DietPi-Banner | Allow custom banner entry

+ DietPi-PreBoot | Moved Fire3 TTY2 workaround into PreBoot + tiny coding/wording

+ DietPi-PreBoot | Moved applying install stage on first boot into PreBoot, since no first run steps are done in DietPi-Boot anymore

+ DietPi-Boot | NanoPi Fire3 TTY2 workaround has been moved into DietPi-PreBoot; Moved applying install stage on first boot as well, since no first run steps are left anymore

+ DietPi-Patch | Skip single /dietpi/conf/ file removal on v6.18 => v6.19 since we remove the whole dir on v6.19 => v6.20 + DietPi-Patch | v6.22 patch: Fix wrong mpd.conf path and wrong user data global variable call + DietPi-Patch | Minor coding

+ DietPi-Globals | Tiny coding/reorder + default RC version update

Fourdee · 2019-03-21T18:37:50Z

@MichaIng

Sorry for coding so much around your banner commit

No worries, all good 👍

There are two issues that I would like to resolve, but require your help due to lack of devices:

The XU4, yep, we need to get in touch with Meveric. Will do that when I can.

Same for the Rock64, will run local tests and find the solution.

Regardless, the above can wait for v6.23. No need to hold up v6.22 for them?

Fourdee · 2019-03-21T18:39:35Z

@MichaIng

Only reliable solution I found with array usage is to write the commands to a file and source/execute it back. But that's way too complicated IMO.

Yep, the plan with aOBTAIN was to allow us to re-obtain on the fly without needing to have multiple copies of the command in the script.
But yeah, obtain network was the only real one that we needed that for I believe.

Fourdee · 2019-03-21T19:03:37Z

@MichaIng

Custom banner entry | Hello World!

Very nice 👍 💘

+ DietPi-PreBoot | Syntax

+ DietPi-Patch | Syntax

+ DietPi-Banner | Make FQDN and NIS differentiation clearer

MichaIng · 2019-03-21T19:58:02Z

@Fourdee

Yep, the plan with aOBTAIN was to allow us to re-obtain on the fly without needing to have multiple copies of the command in the script.

Currently there is only the main banner where we call these commands. When something in the future is obtained on different parts of the script, I would create a function instead. This would have been the other possibility btw:

Obtain_1(){ command 1; }
Obtain_2(){ command 2; }
...

And then call via $(Obtain_$i).

About domainname command:

Program name:
       {yp,nis,}domainname=hostname -y
       dnsdomainname=hostname -d
...
    -y, --yp, --nis        NIS/YP domain name

https://en.wikipedia.org/wiki/Network_Information_Service
Without explicitly setting this (non-permanently via -F) I always have output (none) on all machines. I guess most users not use NIS, also since LDAP is more common for such purpose nowadays?

I changed the banner to now show the FQDN/hostname and NIS domainname, to make the difference clearer. If NIS/YP is not used, then FQDN will show everything relevant for most users. The short hostname is not too useful and already part of the console prompt string (PS1).

+ DietPi-Patch | Syntax

+ DietPi-PreBoot | Syntax

MichaIng

Looks and works great for me. Will merge into Beta

MichaIng and others added 12 commits March 17, 2019 03:32

META | Add further links to the Additional Software list

da4eefe

Create myip.php

1a45858

#2627 (comment)

Merge branch 'dev' of https://github.com/Fourdee/DietPi into dev

e538fc7

v6.22

509f95f

+ Improve code to check for forwarding/proxy etc.

v6.22

07051e8

+ WIP dietpi-banner changes. NB: need to add back in reobtain IP details if not found at time.

v6.22

fd79246

+ Tweaks

v6.22

8bcbed6

+ Minor tweak

v6.22

0619acc

+ dietpi-banner hostname option #2627 (comment)

v6.22

c8989dd

+ Minor ordering

v6.22

d7daf9f

+ Domainname: #2627

v6.22

ed8e4b7

beta v2

Fourdee added the Beta 🧪 Issues specific to the Beta branch testing label Mar 19, 2019

Fourdee added this to the v6.22 milestone Mar 19, 2019

Fourdee requested a review from MichaIng March 19, 2019 15:02

v6.22

f44da31

+ Weather and uptime: #2627

MichaIng changed the title ~~Beta 2~~ Beta v6.22.2 Mar 19, 2019

MichaIng assigned Fourdee and MichaIng Mar 19, 2019

MichaIng added 4 commits March 19, 2019 18:53

v6.22

fa40a75

+ myip.php | Minor alignment and wording

v6.22

9ef89c9

+ DietPi-Banner | Function reorder and minor coding

v6.22

ddf62f0

+ DietPi-Globals | G_CHECK_VALIDINT(): Failsafe: Assure $disable_error is either 1 or 0 and that "unset disable_error" always affects the non-local variable if this was set to 1 + DietPi-Globals | G_CHECK_FREESPACE(): Fix MiB => GiB conversion (*1024) and minor coding

v6.22

668d50d

+ DietPi-Banner | Further code simplifications and consistency

MichaIng added 4 commits March 20, 2019 22:27

v6.22

2225fb6

+ DietPi-Banner | Allow custom banner entry

v6.22

12bbd31

+ DietPi-PreBoot | Moved Fire3 TTY2 workaround into PreBoot + tiny coding/wording

v6.22

5b0a74b

+ DietPi-PreBoot | Moved applying install stage on first boot into PreBoot, since no first run steps are done in DietPi-Boot anymore

v6.22

c88095f

+ DietPi-Boot | NanoPi Fire3 TTY2 workaround has been moved into DietPi-PreBoot; Moved applying install stage on first boot as well, since no first run steps are left anymore

MichaIng added 2 commits March 21, 2019 02:36

v6.22

33669ef

+ DietPi-Patch | Skip single /dietpi/conf/ file removal on v6.18 => v6.19 since we remove the whole dir on v6.19 => v6.20 + DietPi-Patch | v6.22 patch: Fix wrong mpd.conf path and wrong user data global variable call + DietPi-Patch | Minor coding

v6.22

fe001fc

+ DietPi-Globals | Tiny coding/reorder + default RC version update

MichaIng mentioned this pull request Mar 21, 2019

Beta v6.22.1 #2640

Merged

MichaIng added 3 commits March 21, 2019 20:04

v6.22

76f7609

+ DietPi-PreBoot | Syntax

v6.22

ffe7c16

+ DietPi-Patch | Syntax

v6.22

22b7431

+ DietPi-Banner | Make FQDN and NIS differentiation clearer

MichaIng added 2 commits March 21, 2019 23:58

v6.22

9490218

+ DietPi-Patch | Syntax

v6.22

fe434af

+ DietPi-PreBoot | Syntax

MichaIng approved these changes Mar 21, 2019

View reviewed changes

MichaIng merged commit 523df58 into beta Mar 21, 2019

MichaIng mentioned this pull request Mar 21, 2019

Open Beta v6.22 | Please help testing and hardening the upcoming release #2632

Closed

1 task

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Beta v6.22.2 #2643

Beta v6.22.2 #2643

Fourdee commented Mar 19, 2019 •

edited by MichaIng

Loading

Fourdee commented Mar 19, 2019

MichaIng commented Mar 19, 2019

MichaIng commented Mar 20, 2019 •

edited

Loading

Fourdee commented Mar 21, 2019

Fourdee commented Mar 21, 2019

Fourdee commented Mar 21, 2019

MichaIng commented Mar 21, 2019 •

edited

Loading

MichaIng left a comment

Beta v6.22.2 #2643

Beta v6.22.2 #2643

Conversation

Fourdee commented Mar 19, 2019 • edited by MichaIng Loading

Beta v6.22.2

Changes / Improvements / Optimisations (since v6.22.1)

Known/Outstanding Issues

Fourdee commented Mar 19, 2019

MichaIng commented Mar 19, 2019

MichaIng commented Mar 20, 2019 • edited Loading

Fourdee commented Mar 21, 2019

Fourdee commented Mar 21, 2019

Fourdee commented Mar 21, 2019

MichaIng commented Mar 21, 2019 • edited Loading

MichaIng left a comment

Choose a reason for hiding this comment

Fourdee commented Mar 19, 2019 •

edited by MichaIng

Loading

MichaIng commented Mar 20, 2019 •

edited

Loading

MichaIng commented Mar 21, 2019 •

edited

Loading