Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DietPi-Sync | Empty source check, dry run merge and minor fixes/enhancements #2606

Merged
merged 7 commits into from
Mar 2, 2019

Conversation

MichaIng
Copy link
Owner

@MichaIng MichaIng commented Mar 2, 2019

Status: Ready

  • DietPi-Drive_Manager mount selection exit code and last item removal
  • Changelog

Testing:

  • VM Jessie
  • VM Stretch
  • VM Buster

Reference: #2602

Commit list/description:

  • DietPi-Sync | Check and abort sync, if the source dir is empty, e.g. due to inactive mount point
  • DietPi-Sync | Merge dry run into real sync, give a summary and allow user to continue, cancel or view the dry run log
  • DietPi-Sync | Do not kill rsync processes, rely on systemctl to stop the service gracefully. Leave e.g. running syncs to end user to finish/handle, so we do no break anything unexpectedly.
  • DietPi-Sync | Log to persistent /var/tmp/dietpi/logs instead of RAMlog, if target dir is not available
  • DietPi-Sync | Move "--delete-excluded" option into delete mode selection, so with delete mode disabled, really nothing is removed from target dir.
  • DietPi-Sync | Remove rsync "-h" option, since free space check expects bytes
  • DietPi-Sync | Fix file count scrapes from dry run summary, since $6 and $8 do not necessarily match file and dir count, dependant on the existence of any file/dir/link/...
  • DietPi-Sync | GUI: Use last chosen menu item as new default
  • DietPi-Sync | Prevent theoretically possible menu loop, reverting to main menu in case of invalid integer
  • DietPi-Sync | On mount list selection, only apply path, if an actual selection has been made: To be added to DietPi-Drive_Manager as well!
  • DietPi-Sync | Minor coding and wording
  • DietPi-Drive_Manager | RootFS_Move(): Failsafe root mount replacement if more than one space is between "/" and "auto"
  • DietPi-Drive_Manager | RootFS_Move(): Do not automatically reboot, instead leave choice to user
  • DietPi-Drive_Manager | Mount selection: Always remove old output file to prevent obsolete value in parent script in case of user cancel. Instead when user cancels selection, set EXIT_CODE=1 to be checked in parent script.
  • DietPi-Drive_Manager | Prevent theoretically possible menu loop, reverting to main menu in case of invalid integer
  • DietPi-Drive_Manager | Minor coding and wording
  • DietPi-Backup | Prevent theoretically possible menu loop, reverting to main menu in case of invalid integer
  • DietPi-Backup | Minor coding
  • CHANGELOG | DietPi-Sync: Sync will abort now if the source dir is empty and merged dry run into real sync
  • DietPi-Patch | Remove obsolete DietPi-Sync log

+ DietPi-Sync | Check and abort sync, if the source dir is empty, e.g. due to inactive mount point
+ DietPi-Sync | Merge dry run into real sync, give a summary and allow user to continue, cancel or view the dry run log
+ DietPi-Sync | Log to persistent /var/tmp/dietpi/logs instead of RAMlog, if target dir is not available
+ DietPi-Sync | Remove rsync "-h" option, since free space check expects bytes
+ DietPi-Sync | Fix file count scrapes from dry run summary, since $6 and $8 do not necessarily match file and dir count, dependant on the existence of any file/dir/link/...
+ DietPi-Sync | Minor coding and wording
@MichaIng MichaIng added this to the v6.22 milestone Mar 2, 2019
@MichaIng MichaIng self-assigned this Mar 2, 2019
@MichaIng MichaIng changed the title v6.22 DietPi-Sync | Empty source check, dry run merge and minor fixes/enhancements Mar 2, 2019
MichaIng added 6 commits March 2, 2019 16:44
+ DietPi-Sync | Fix wrong line scrape for dry run summary
+ DietPi-Sync | GUI: Use last chosen menu item as new default
+ DietPi-Sync | Prevent theoretically possible menu loop, reverting to main menu in case of invalid integer
+ DietPi-Sync | On mount list selection, only apply path, if an actual selection has been made: To be added to DietPi-Drive_Manager as well!
+ DietPi-Sync | Minor coding and wording
+ DietPi-Drive_Manager | 
+ DietPi-Drive_Manager |
+ DietPi-Drive_Manager | Typo
+ DietPi-Backup | Prevent theoretically possible menu loop, reverting to main menu in case of invalid integer
+ DietPi-Backup | Minor coding
+ CHANGELOG | DietPi-Sync: Sync will abort now if the source dir is empty and merged dry run into real sync
+ DietPi-Patch | Remove obsolete DietPi-Sync log
@MichaIng MichaIng merged commit c3c3956 into dev Mar 2, 2019
@MichaIng MichaIng deleted the sync branch March 2, 2019 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant