Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DietPi-Obtain_network_details | Skip loading DietPi-Globals #2574

Merged
merged 1 commit into from
Feb 22, 2019
Merged

DietPi-Obtain_network_details | Skip loading DietPi-Globals #2574

merged 1 commit into from
Feb 22, 2019

Conversation

MichaIng
Copy link
Owner

@MichaIng MichaIng commented Feb 21, 2019 •
edited
Loading

Status: Ready

Commit list/description:

  • DietPi-Obtain_network_details | Skip loading DietPi-Globals, since we don't use them at all. Add exit path in case of concurrent execution instead.

@Fourdee
Another case where we can skip loading DietPi-Globals. Just the concurrency included with G_INIT should stay, just exiting silently here.

@MichaIng
v6.22
5eff332 
+ DietPi-Obtain_network_details | Skip loading DietPi-Globals, since we don't use them at all. Add exit path in case of concurrent execution instead.
@MichaIng MichaIng added Enhancement 💨 Coding 📑 Improving code stability, performance and consistancy labels Feb 21, 2019
@MichaIng MichaIng added this to the v6.22 milestone Feb 21, 2019
@MichaIng MichaIng self-assigned this Feb 21, 2019
@MichaIng MichaIng requested a review from Fourdee February 21, 2019 12:47
@MichaIng MichaIng merged commit 4c6a3bc into dev Feb 22, 2019
@MichaIng MichaIng deleted the obtain_network branch February 22, 2019 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fourdee Fourdee Awaiting requested review from Fourdee

Assignees

@MichaIng MichaIng

Labels
Coding 📑 Improving code stability, performance and consistancy Enhancement 💨
Projects
None yet
Milestone
v6.22
Development

Successfully merging this pull request may close these issues.
1 participant
@MichaIng