Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DietPi-Start_kodi | Do not load DietPi-Globals, since G_HW_MODEL is required only #2565

Merged
merged 1 commit into from
Feb 19, 2019
Merged

DietPi-Start_kodi | Do not load DietPi-Globals, since G_HW_MODEL is required only #2565

merged 1 commit into from
Feb 19, 2019

Conversation

MichaIng
Copy link
Owner

Status: Ready

Commit list/description:

  • DietPi-Start_kodi | Do not load DietPi-Globals, since G_HW_MODEL is required only

@Fourdee
Or did I oversee something?

@MichaIng
v6.22
059595d 
+ DietPi-Start_kodi | Do not load DietPi-Globals, since G_HW_MODEL is required only
@MichaIng MichaIng added this to the v6.22 milestone Feb 18, 2019
@MichaIng MichaIng self-assigned this Feb 18, 2019
@MichaIng MichaIng requested a review from Fourdee February 18, 2019 11:03
@Fourdee
Copy link
Collaborator

Fourdee commented Feb 19, 2019

@MichaIng

Or did I oversee something?

Nope, looks good 👍

I believe we added it for consistency. But if unused, save some time during init 👍

@Fourdee Fourdee merged commit b277c8c into dev Feb 19, 2019
@MichaIng MichaIng deleted the start_kodi branch February 19, 2019 21:34
@MichaIng MichaIng added the Coding 📑 Improving code stability, performance and consistancy label Feb 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fourdee Fourdee Awaiting requested review from Fourdee

Assignees

@MichaIng MichaIng

Labels
Coding 📑 Improving code stability, performance and consistancy Enhancement 💨
Projects
None yet
Milestone
v6.22
Development

Successfully merging this pull request may close these issues.
2 participants
@MichaIng @Fourdee