Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DietPi-Set_Hardware | I-Sabre-K2M: Fix module source build, add informational comments #2550

Merged
merged 5 commits into from
Feb 20, 2019

Conversation

MichaIng
Copy link
Owner

@MichaIng MichaIng commented Feb 14, 2019

Status: Testing

  • Changelog
  • ln -s /usr/bin/gcc-4.9 /usr/bin/gcc and ln -s /usr/bin/g++-4.9 /usr/bin/g++
    • The 4.9 packages do not place that symlink.
    • But those would override/fail if other gcc/g++ versions are installed, e.g. simply gcc/g++ packages from repo (via build-essential)...
    • At best we find a way to tell make to use the /usr/bin/gcc-4.9/g++-4.9 binaries
      EDIT: make CC=gcc-4.9 CXX=g++-4.9, but needs check if this is handed over to the sub make calls as well.
  • Is g++ actually required? User reported success without g++ binary linked.

Reference: https://github.com/Fourdee/DietPi/issues/2547

Commit list/description:

  • DietPi-Set_Hardware | I-Sabre-K2M: Fix module source build, add informational comments
  • DietPi-Set_Hardware | I-Sabre-K2M: "gcc-4.9" should be sufficient for build
  • DietPi-Set_Hardware | I-Sabre-K2M: Add correct gcc binary to make commands

+ DietPi-Set_Hardware | I-Sabre-K2M: Fix module source build, add informational comments
+ CHANGELOG | Resolved an issue where I-Sabre-K2M sound card selection failed
@MichaIng
Copy link
Owner Author

MichaIng commented Feb 16, 2019

@Fourdee
Did you do manual edits compared to https://github.com/SatoruKawase/I-Sabre-K2M according to the README.md contained in your provided archive?
There have been quite some commits done from our version on: https://github.com/SatoruKawase/I-Sabre-K2M/commits/master

Otherwise use the GitHub archive directly instead of hosting it ourself?


Okay gcc should be sufficient and according to research, make CC=gcc-4,9 should apply this binary to all sub make calls. However some final test should be done.

Question about g++ forwarded: SatoruKawase/I-Sabre-K2M#3

+ DietPi-Set_Hardware | I-Sabre-K2M: "gcc-4.9" should be sufficient for build
+ DietPi-Set_Hardware | I-Sabre-K2M: Add correct gcc binary to make commands
+ DietPi-Set_Hardware | I-Sabre-K2M: Minor comment fix
@Fourdee
Copy link
Collaborator

Fourdee commented Feb 20, 2019

@MichaIng

Did you do manual edits compared to https://github.com/SatoruKawase/I-Sabre-K2M according to the README.md contained in your provided archive?

No manual edits, used the source code provided by Audiophonics directly for the DAC.

@Fourdee
Copy link
Collaborator

Fourdee commented Feb 20, 2019

@MichaIng

Thanks for fixing this 👍

Will merge and test.

@Fourdee Fourdee merged commit a3c06dc into dev Feb 20, 2019
@Fourdee
Copy link
Collaborator

Fourdee commented Feb 20, 2019

🈯️ Works a charm, nice one @MichaIng 👍

@MichaIng MichaIng deleted the i-sabre-k2m branch February 20, 2019 19:43
@MichaIng
Copy link
Owner Author

@Fourdee

No manual edits, used the source code provided by Audiophonics directly for the DAC.

Okay, then we might want to update our source due to the commits that have been done in between.

🈯️ Works a charm, nice one @MichaIng 👍

Perfect, so it's proven that g++ is not required, gcc sufficient.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants