Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DietPi-Login | Fix and tuning #2544

Merged
merged 6 commits into from
Feb 15, 2019
Merged

DietPi-Login | Fix and tuning #2544

merged 6 commits into from
Feb 15, 2019

Conversation

MichaIng
Copy link
Owner

@MichaIng MichaIng commented Feb 13, 2019 •
edited
Loading

Status: Testing

Commit list/description:

  • DietPi-Login | Fix changed AUTO_START_INDEX => auto_start_index
  • DietPi-Login | Check for PostBoot finish only once before loop: Tiny speed-up of following loops
  • DietPi-Login | Check for AUTO_SETUP_AUTOMATED only once before loop, to have "export G_USER_INPUTS=0" (on invalid install state) not being overwritten on next loop
  • Make above checks work without globals loaded

@MichaIng
v6.22
2c5d01a 
+ DietPi-Login | Fix changed AUTO_START_INDEX => auto_start_index
+ DietPi-Login | Check for PostBoot finish only once before loop: Tiny speed-up of following loops
+ DietPi-Login | Check for AUTO_SETUP_AUTOMATED only once before loop, to have "export G_USER_INPUTS=0" not being overwritten on error
@MichaIng MichaIng added this to the v6.22 milestone Feb 13, 2019
@MichaIng MichaIng self-assigned this Feb 13, 2019
@MichaIng MichaIng requested a review from Fourdee February 13, 2019 21:22
@MichaIng
Copy link
Owner Author

MichaIng commented Feb 13, 2019 •
edited
Loading

@Fourdee

(( ! $G_USER_INPUTS )) && additional_text='Automated setup is in progress, the system will reboot automatically when completed.'

So this is not 100% true, if no additional software was selected, right? Simply leave the hint to finish setup on active terminal session? We could even print the TTY/pts where the active update/install is attached to.

@Fourdee
Copy link
Collaborator

Fourdee commented Feb 15, 2019

@MichaIng

So this is not 100% true, if no additional software was selected, right?

Good point 👍 Will take a look.

Daniel Knight added 5 commits February 15, 2019 15:21
v6.22
7c9d752 
#Sudo required for non-root

dietpi@DietPi:~$ systemctl status dietpi-postboot
Failed to connect to bus: No such file or directory
v6.22
82fe2a7 
+ Tweaks
v6.22
a206e54 
+ Might also need a failsafe int check
v6.22
a970f39 
+ Count \o/
v6.22
ffc3eec 
+ Switch to dietpi-login, to ensure pgrep better match
@Fourdee
Copy link
Collaborator

Fourdee commented Feb 15, 2019 •
edited
Loading

made some additional changes/tweaks , will merge and test.

@Fourdee Fourdee merged commit dd91c40 into dev Feb 15, 2019
MichaIng
MichaIng commented Feb 15, 2019
View reviewed changes
dietpi/login Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fourdee Fourdee Awaiting requested review from Fourdee

Assignees

@MichaIng MichaIng

Labels
Bug 🐞 Enhancement 💨
Projects
None yet
Milestone
v6.22
Development

Successfully merging this pull request may close these issues.
2 participants
@MichaIng @Fourdee