Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DietPi-Software | Airsonic: Update installer to latest version #2410

Merged
merged 5 commits into from
Jan 15, 2019
Merged

Conversation

MichaIng
Copy link
Owner

@MichaIng MichaIng commented Jan 13, 2019

Status: Ready

Testing:

Commit list/description:

  • DietPi-Software | Airsonic: Install latest version via api.github.com
  • DietPi-Software | Airsonic: If user already exists, update via usermod instead of attempting useradd
  • DietPi-Software | Airsonic: Move airsonic user home dir to dietpi_userdata as well
  • DietPi-Software | Minor coding
  • DietPi-Software | Java: "ca-certificates-java" is now dependency of "openjdk-8-jre-headless" on all distro versions, so do not manually install
  • DietPi-Software | Java: "ca-certificates-java" dependencies now allow Java 8 only on all distro versions, Java 9+10 have been dropped mostly, so we don't require reinstall workaround anymore
  • DietPi-Software | Java: Install headless packages on Jessie as well
  • DietPi-Software | Java: Add all Java related packages to backports priority pin on Jessie, to allow automated APT upgrades for all of them

+ DietPi-Software | Airsonic: Install latest version via api.github.com
+ DietPi-Software | Airsonic: If user already exists, update via usermod instead of attempting useradd
+ DietPi-Software | Airsonic: Move airsonic home dir to dietpi_userdata as well
+ DietPi-Software | Minor coding
@MichaIng MichaIng added this to the v6.20 milestone Jan 13, 2019
@MichaIng MichaIng self-assigned this Jan 13, 2019
@MichaIng MichaIng requested a review from Fourdee January 13, 2019 14:46
+ CHANGELOG | Airsonic: Now installs the latest upstream version automatically
@MichaIng
Copy link
Owner Author

MichaIng commented Jan 13, 2019

Info: https://github.com/Fourdee/DietPi/issues/2400#issuecomment-453847053

  • Starts without JDK (JRE only), no error message, but web UI loads forever. Investigating...
  • Strange had web UI login one time with JDK, now on retest it does not work at all 🤔.
  • Okay now it loads, simply takes veeery long... Generally web UI behaves very slow on my VM... 100% CPU load for ~10 seconds during each navigation step.
  • Retest with the version from dietpi.com... Same thing:
    • I start the process, wait until the it has fully finished, which already takes ~2 minutes.
    • CPU usage goes down, output says Airsonic started up in xxx seconds.
    • Then I try web UI access. For at least 1 minute, it just loads, no CPU usage shows up, no process output. Then after some time, CPU usage goes up and after another minute, finally the login screen shows up. Each navigation then takes ~10 seconds (or more) with full CPU usage.
  • Retest without JDK... Works, took ~5 minutes for login page to open on first access... Second access then is fast. Okay now also navigation is fast. Seems to be much caching and var file creation is done on first access.
  • Jep caching it is: After one page was opened the first time, which takes 10-30 seconds, the second time it is much faster.

There is a Tomcat and a standalone version available on their homepage, but both link to the same binary, the one which is also available on GitHub. Looks like active Tomcat server is used if available, otherwise internal once is started (I see tomcat.* dirs in /tmp).

It has an internal version check, but no updater. Update method indeed is downloading the new .war.

450M RAM usage after first login. Did I say that I am no fans of Java? 😉

  • Memory limit via cmd argument set to 200M, but that doesn't seem to be valid for the whole java process.

Okay result is, that JRE is sufficient and the new version from GitHub works fine. We don't need to change something on reinstall, new .war in place as an update (or not) and we are fine.


Test on Jessie/Buster:

  • Interesting, first login is much faster here. The minutes with 0 CPU activity are not there, directly full load and after ~10 seconds, login is done.
  • Same on Buster, only Stretch takes somehow so long 🤔.
  • 🈯️ Okay final retest and now on Stretch it's faster as well. Perhaps some network/VM CPU share issue, since host ran some other stuff.

+ DietPi-Software | Airsonic: Use wget instead of Download_Install(), since we don't download a 7z archive anymore
+ DietPi-Software | Airsonic: wget -O requires a destination file name
+ DietPi-Software | Java: "ca-certificates-java" is now dependency of "openjdk-8-jre-headless" on all distro versions, so do not manually install
+ DietPi-Software | Java: "ca-certificates-java" dependencies now allow Java 8 only on all distro versions, Java 9+10 have been dropped mostly, so we don't require reinstall workaround anymore
+ DietPi-Software | Java: Install headless packages on Jessie as well
+ DietPi-Software | Java: Add all Java related packages to backports priority pin on Jessie, to allow automated APT upgrades for all of them
@Fourdee
Copy link
Collaborator

Fourdee commented Jan 15, 2019

@MichaIng

450M RAM usage after first login. Did I say that I am no fans of Java?

Agree 👍 😉

PR looks good, many thanks, will merge.

@Fourdee Fourdee merged commit da5370a into dev Jan 15, 2019
@MichaIng MichaIng deleted the airsonic branch January 15, 2019 13:21
@Fourdee Fourdee mentioned this pull request Jan 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants