DietPi-Software | Simplify and consistent config file naming #2312
Conversation
There was a problem hiding this comment.
@Fourdee
Ah the idea was to just use conf here for config files?
Shall we then do this for other software titles as well?
Only concern I have is, if e.g. we remove a software title from DietPi and replace the ID, the old dietpi-software versions will not recognize and place a wrong config file.
If those have a more specific name, then at least the user will face a meaningful error, can upgrade, ask or inform himself about dropped software.
MichaIng
changed the title
|
@Fourdee |
MichaIng
added
Enhancement 💨
META
|
Damn... /etc/nginx/conf.d is main config level while /etc/nginx/sites-dietpi was server config level (included by sites-enabled/default).
|
Should not matter, as master branch will not change until we PR. Just need to make sure we update |
Ignore it for now, testing/getting it ready only. |
| echo '# Redirect Cal/CardDAV requests to ownCloud endpoint: | ||
| location = /.well-known/carddav { | ||
| return 301 $scheme://$host/owncloud/remote.php/dav; | ||
| } | ||
| location = /.well-known/caldav { | ||
| return 301 $scheme://$host/owncloud/remote.php/dav; | ||
| }' > /etc/nginx/sites-dietpi/dietpi-dav_redirect.config | ||
| }' > /etc/nginx/sites-dietpi/dietpi-dav_redirect.conf |
There was a problem hiding this comment.
Needs verifying if Nginx supports the .conf extension. Might require .config?
There was a problem hiding this comment.
See it passed local testing, will merge and test also:
https://github.com/Fourdee/DietPi/issues/2308#issuecomment-443547842
There was a problem hiding this comment.
@Fourdee
Jep file ending can be freely chosen by include directive. Also inside conf.d it is .conf, similar to all other webservers. So it's more constant to stay with this.
|
Thanks Micha, looks good, will merge 👍 |
Status: Ready
Commit list/description:
... all of them 😄