Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DietPi-Software | Reinstalls: Better handle existing configs and install dirs #2214

Merged
merged 11 commits into from
Nov 5, 2018

Conversation

MichaIng
Copy link
Owner

@MichaIng MichaIng commented Nov 2, 2018

Status: Ready

  • Check further install titles
    • Enough for now, this is a larger task, most properly over the next multiple releases.

Testing
🈯️ Jackett + reinstall
🈯️ RoonServer + reinstall
🈯️ MariaDB, SQLite and Redis after PHP
🈯️ phpBB + reinstall

[ INFO ] DietPi-Software | Forums install dir "/var/www/phpBB3" already exists. Download and install steps will be skipped.
 - Please manually backup your config files+data, remove the install dir and rerun "dietpi-software (re)install 54" if you need to reinstall.
 - If you want to update the Forums instance, please follow the instructions from WebUI ACP.
...
[ INFO ] DietPi-Create_MySQL_DB | "phpbb3" MariaDB database already exists. Aborting...

Reference:

Commit list/description:

  • DietPi-Software | Jackett: Fix reinstall in case of existent install dir
  • DietPi-Software | RoonServer: Skip download and install, if already install dir already exist; Rely on internal auto updater
  • DietPi-Software | Minor coding
  • DietPi-Software | Assure that required database PHP modules are installed as well, if PHP was already installed before
  • DietPi-Software | phpBB: Install v3.2.3, use bzip2 archive => lower download size
  • DietPi-Software | phpBB: Skip Download_Install, if install already exists. Ask user for manual config/data/plugin backup and install dir removal, if reinstall required; Updates should be applied via internal update package method.
  • DietPi-Create_MySQL_DB | Skip database creation, if already existent. Creation anyway fails otherwise.
  • DietPi-Software | Plex/Transmission: Prevent doubled service file entries on reinstall

+ DietPi-Software | Jackett: Fix reinstall in case of existent install dir
+ DietPi-Software | RoonServer: Skip download and install, if already install dir already exist; Rely on internal auto updater
+ DietPi-Software | Minor coding
+ CHANGELOG | Jackett and RoonServer reinstall fix
+ DietPi-Software | Add forgotten aSOFTWARE_AVAIL_G_DISTRO usage
+ DietPi-Software | Assure that required database PHP modules are installed as well, if PHP was already installed before
+ CHANGELOG | PHP/databases: Resolved an issue where PHP database modules were not installed
+ DietPi-Software | phpBB: Install v3.2.3, use bzip2 archive => lower download size
+ DietPi-Software | phpBB: Skip Download_Install, if install already exists. Ask user for manual config/data/plugin backup and install dir removal, if reinstall required; Updates should be applied via internal update package method.
+ DietPi-Create_MySQL_DB | Skip database creation, if already existent. Creation anyway fails otherwise.
+ DietPi-Software | Plex/Transmission: Prevent doubled service file entries on reinstall
+ DietPi-Software | Syntax
@MichaIng
Copy link
Owner Author

MichaIng commented Nov 3, 2018

My goodness, Mono is quite monster. "Quick" testing of the installs impossible. Looooong Mono install, looong compiling, loooong loading of software run by Mono... Reminds of of Java, although way better in terms of RAM usage πŸ˜‰.

+ DietPi-Software | RoonServer: Minor prompt fix
+ DietPi-Software | Workaround issue with new single loop pre-req marking: In case software_id > 85 marks a webserver to be installed, PHP was not marked any more, since webservers ID already passed. Now when webserver is marked, PHP is marked by the current software ID. Same for desktops and xserver!
@MichaIng
Copy link
Owner Author

MichaIng commented Nov 4, 2018

@Fourdee
Ready to merge from my point of view. Fixes some issues with last dietpi-software change and reported software reinstalls (wrong unpack target when existent).

I will go on checking other software installs, but will do this in steps.

We have doubled webserver + PHP install fix, but does not harm, my second step will just be ignored due to =1 already the case. Will rework dependencies to have a merged consistent method.

@Fourdee
Copy link
Collaborator

Fourdee commented Nov 5, 2018

@MichaIng

Looks good, great work πŸ‘ Will merge.

@Fourdee Fourdee merged commit b930ccf into dev Nov 5, 2018
@MichaIng MichaIng deleted the reinstall-fix branch November 5, 2018 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants