-
-
Notifications
You must be signed in to change notification settings - Fork 504
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DietPi-Drive_Manager | Several #2062
Conversation
+ DietPi-Drive_Manager | Allow sub directories for samba mounts: https://dietpi.com/phpbb/viewtopic.php?f=11&t=4649 + DietPi-Drive_Manager | When scraping device detection commands, use "continue" instead of "break" to just skip empty lines instead of breaking the whole loop + DietPi-Drive_Manager | Keep file permissions when copying fstab + DietPi-Drive_Manager | "Destroy()" call is no needed directly before "exit", since it is now called on all kinds of exits via exit trap. + DietPi-Drive_Manager | Replace "cat" with "echo" for writing content to file: https://github.com/Fourdee/DietPi/issues/1510#issuecomment-419722975 + DietPi-Drive_Manager | Further minor code and stability improvements
Looks good nice one 👍
Yep, the break (due to empty line) would stop the loop from processing. I had to add this in, as, some of the scrapes (i cant remember which), if they had a blank output (no results), the line was still being counted, creating an init of a blank entry. Break should be fine to use, as if no value, we can assume to stop. Continue would add an extra |
Great work, merged for testing 👍 |
@Fourdee
|
Yes it does! However, I lack any NVMe drives. £60 for cheapest one I can find, will have to wait. |
Status: ready
🈴 Drives and partitions both are listed as headers (doubled)€: Fixed with Fourdee@daa6ab6References:
Commit list/description:
Currently, if I am not totally mistaken, an empty line would break the whole output command/file loop. This should never be an issue, since these commands do not have empty lines. But if we already check (failsafe), then continue should do the job, skipping current line and go on with the next.