Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DietPi-Software | ownCloud/Nextcloud: Fix/Polish Phase II #1272

Merged
merged 11 commits into from
Dec 7, 2017
Merged

DietPi-Software | ownCloud/Nextcloud: Fix/Polish Phase II #1272

merged 11 commits into from
Dec 7, 2017

Conversation

MichaIng
Copy link
Owner

@MichaIng MichaIng commented Dec 5, 2017

  • Enable maintenance mode before reinstallation via patchfile to suppress error caused by stopped MySQL.
  • Suppress Apache2 messaged about already enabled modules and sites.
  • Suppress occ maintenance:install error message, if instance is already installed.
  • Fixed typo about ncc command.
  • Intelligent handling of maintenance mode during dietpi-services.
  • Main folders should be removed after mysql user dropping, otherwise we can't find user names.
  • Correctly "add" cronjob, instead of overwrite.

@MichaIng
Copy link
Owner Author

MichaIng commented Dec 6, 2017

Just realized, that bashrc aliases are not present inside scripts. Therefore we would need binaries:
nano /usr/local/bin/occ

#!/bin/bash
sudo -u www-data php /var/www/owncloud/occ $*

Does work as expected.

Or we just use the full command inside our scripts?

Personally I would go with the binaries, because it is also most easy and safe to just handle files instead of conditionally adjust their content 😄. But in the end it is absolutely not important if and how.

@MichaIng
Copy link
Owner Author

MichaIng commented Dec 6, 2017

Testing:

  • Reinstallation/dietpi-update works fine now without unnecessary warnings and existing installation stay untouched, just selective secure enhancements are done, if not yet applied by user.
  • Uninstallation
  • Fresh installation

@Fourdee
Copy link
Collaborator

Fourdee commented Dec 7, 2017

@MichaIng

Many thanks 👍

@Fourdee Fourdee merged commit bcc10f3 into MichaIng:testing Dec 7, 2017
@MichaIng MichaIng deleted the patch-1 branch December 7, 2017 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants