Fix warning when running scp over openssh-server #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When running scp over openssh-server in dietpi I saw the following problem: /boot/dietpi/login: line 41: [: too many arguments Adding more debug information: ++ sed -n 1p /boot/dietpi/.hw_model + HW_MODEL=1 ++ sed -n 2p /boot/dietpi/.hw_model + HW_MODEL_DESCRIPTION='Raspberry Pi 1 (512MB)' ++ sed -n 3p /boot/dietpi/.hw_model + DISTRO=1 ++ cat /boot/dietpi/.install_stage + DIETPI_INSTALL_STAGE=1 ++ cat /boot/dietpi/.auto_boot_index + AUTO_BOOT_INDEX=0 ++ cat /boot/dietpi/.version + DIETPI_VERSION=51 + (( 1 == 1 )) + '[' -z '' ']' ++ tty + '[' not a tty == /dev/tty1 ']' /boot/dietpi/login: line 41: [: too many arguments + /boot/dietpi/dietpi-banner 1 The safe way to go is to use $(tty) inside double quotes.
|
Hi tdaitx, Great find, appreciate the fix 👍 This will also be released in a few days with DietPi _v52.img. |
Fourdee
added a commit
that referenced
this pull request
May 6, 2015
Fix warning when running scp over openssh-server
| @@ -38,7 +38,7 @@ | |||
| if (( $DIETPI_INSTALL_STAGE == 1 )); then | |||
|
|
|||
| #Boot to specific Program | |||
| if [ -z "$DISPLAY" ] && [ $(tty) == /dev/tty1 ]; then | |||
| if [ -z "$DISPLAY" ] && [ "$(tty)" == /dev/tty1 ]; then | |||
There was a problem hiding this comment.
I'll also remove the double parentheses (c style ==) as this is not arithmetic, and, set to double quotes on both input and output values.
if [ "$(tty)" = "/dev/tty1" ]; then
Closed
This was referenced Aug 19, 2017
Closed
Closed
This was referenced Aug 31, 2017
Closed
1 task
1 task
1 task
1 task
1 task
1 task
1 task
1 task
1 task
1 task
1 task
1 task
This was referenced Oct 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running
scpto copy a file to dietpi I saw the following problem:Adding more debug information:
The safe way to go is to use $(tty) inside double quotes.
Note: I'm using the
openssh-serverpackage, I haven't tested it with dropbear.