Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DietPi-DDNS | Add provider YDNS #5128

Closed
edmundlaugasson opened this issue Jan 3, 2022 · 4 comments · Fixed by #6674
Closed

DietPi-DDNS | Add provider YDNS #5128

edmundlaugasson opened this issue Jan 3, 2022 · 4 comments · Fixed by #6674
Labels
Milestone

Comments

@edmundlaugasson
Copy link

Creating a feature request

Is your feature request related to a problem? Please describe:

As YDNS is free and open-source, then why not include it into DietPi.

Describe the solution you'd like:

When opening DietPi-DDNS tool, would like to see YDNS choice there. Appropriate bash DDNS updater script is here.

Describe alternatives you've considered:

There are alternatives available at DietPi-DDNS tool

Additional context

This should work on all supported platforms of DietPi architecture (armhf, aarch64, etc).

@MichaIng MichaIng changed the title [feature request] YDNS support via DietPi-DDNS tool DietPi-DDNS | Add provider YDNS Jan 3, 2022
@MichaIng
Copy link
Owner

MichaIng commented Jan 3, 2022

Many thanks for your request.

Bare API docs are here: https://ydns.io/api/v1/#update
So instead of invoking a whole bash script, we can do a simple curl call like we do in the other cases 🙂.

@TDuffinNTU
Copy link
Contributor

Would this be a good newcomer issue to tackle? From what I can tell I just need to modify dietpi-ddns:

  • Add YDNS to USAGE and as a commandline option via Read()
  • Add YDNS update URI to Apply()
  • Add YDNS-specific option(s) to other methods.

Any other scripts that need updating to accommodate the change?

@MichaIng
Copy link
Owner

MichaIng commented Oct 7, 2023

Jep, only this one script needs change. Searching for e.g. "DuckDNS" though the script and adding respective YDNS blocks should so it.

@MichaIng MichaIng linked a pull request Oct 8, 2023 that will close this issue
MichaIng added a commit to TDuffinNTU/DietPi that referenced this issue Oct 14, 2023
- CHANGELOG | DietPi-DDNS: YDNS has been added to the list of natively supported DDNS providers. Many thanks to @edmundlaugasson for requesting and @TDuffinNTU for implementing it: MichaIng#5128, MichaIng#6674
@MichaIng MichaIng added this to the v8.23 milestone Oct 14, 2023
@MichaIng MichaIng added the Solution available 🥂 Definite solution has been done label Oct 14, 2023
MichaIng pushed a commit that referenced this issue Oct 14, 2023
- DietPi-DDNS | YDNS has been added to the list of natively supported DDNS providers. Many thanks to @edmundlaugasson for requesting and @TDuffinNTU for implementing it: #5128, #6674
@MichaIng
Copy link
Owner

Done with: #6674

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants