Skip to content

Commit

Permalink
v6.26 (#3114)
Browse files Browse the repository at this point in the history
+ DietPi-Config | Run "setupcon --save" after new keyboard layout has been chosen, to force font and cached script renewal. With this, no reboot is required and on Buster, the "console-setup" service fails do this on boot in cases: #2912 (comment)
+ DietPi-Config | Setting the timezone does not require any reboot and in case of locale, only prompt for reboot when user actually chooses one, thus does not cancel.
+ DietPi-FirstBoot | Run "setupcon --save" after new keyboard layout has been applied, to force font and cached script renewal. This solves an issue on Buster, where the "console-setup" service fails to do this on boot in cases: #2912 (comment)
+ DietPi-Patch | Run "setupcon --save" to force font and cached console+keyboard script renewal. This solves an issue on Buster, where the "console-setup" service fails to do this on boot in cases: #2912 (comment)
+ CHANGELOG | Resolved an issue on some Buster systems where console-setup fails on boot to apply keyboard layout and console settings
  • Loading branch information
MichaIng authored Sep 17, 2019
1 parent 9456c21 commit 07e1b84
Show file tree
Hide file tree
Showing 4 changed files with 9 additions and 9 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.txt
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ Changes / Improvements / Optimisations:
Bug Fixes:
- General | Removed an obsolete OpenMediaVault cron job and binary that was leftover on at least one of our images (NanoPi NEO2) and is not part of the current OMV packages, thus save to remove in every case. Many thanks to @kt1024 for reporting this issue: https://github.com/MichaIng/DietPi/issues/2994
- General | Resolved an issue where install of required APT packages for certain scripts could fail in the rare case that APT lists are outdated and old packages are not available in the repo anymore. Many thanks to @Paulisper for reporting this issue: https://github.com/MichaIng/DietPi/issues/2996
- General | Resolved an issue on some Buster systems where console-setup fails on boot to apply keyboard layout and console settings. Many thanks to @jaxjexjox for reporting this issue: https://github.com/MichaIng/DietPi/issues/2912#issuecomment-532100542
- Rock64/RockPro64 | Resolved an issue where DietPi could not obtain the active network adapter and IP, if onboard Ethernet was used. This is because of a kernel-related bug, which seems to cause Ethernet connection instabilities as well in cases. A workaround is applied to all new Rock(Pro)64 images and via DietPi-Update. Many thanks to @svh1985 for reporting this issue, as well as searching and testing the workaround: https://github.com/MichaIng/DietPi/issues/3066
- DietPi-Login | Resolved an issue during first run setup, where DietPi-Software was called with mostly wrong whiptail menu dimensions. This lead to info prompts and menus being quite small, in particular the "Install" menu entry, that one needs to select, being only visible when navigating to the bottom. Many thanks to @pbecks1963 for reporting this issue: https://github.com/MichaIng/DietPi/issues/3053
- DietPi-NordVPN | Resolved an issue where the server menu could have wrong entries or even fail, if foreign files were placed inside the config directory. Many thanks to @svh1985 for reporting this issue and implementing a fix: https://github.com/MichaIng/DietPi/pull/3047
Expand Down
12 changes: 4 additions & 8 deletions dietpi/dietpi-config
Original file line number Diff line number Diff line change
Expand Up @@ -2056,7 +2056,7 @@ Current setting: $user_frequency_min_text" && G_CONFIG_INJECT 'CONFIG_CPU_MIN_FR

'Locale' ": [$locale_current]"
'Timezone' ": [$(</etc/timezone)]"
'Keyboard' ": [$(grep 'XKBLAYOUT=' /etc/default/keyboard | sed 's/^[^=]*=//' | sed 's/"//g')]"
'Keyboard' ": [$(sed -n '/^[[:blank:]]*XKBLAYOUT=/{s/^[^=]*=//;s/"//gp;q}' /etc/default/keyboard)]"

)

Expand All @@ -2068,8 +2068,6 @@ Current setting: $user_frequency_min_text" && G_CONFIG_INJECT 'CONFIG_CPU_MIN_FR

'Locale')

REBOOT_REQUIRED=1

G_FILE_EXISTS /usr/share/i18n/SUPPORTED

G_WHIP_MENU_ARRAY=()
Expand All @@ -2089,27 +2087,25 @@ Current setting: $user_frequency_min_text" && G_CONFIG_INJECT 'CONFIG_CPU_MIN_FR
if G_WHIP_MENU 'Please select a system locale. DietPi will automatically apply this as the default locale:'; then

/DietPi/dietpi/func/dietpi-set_software locale "$G_WHIP_RETURNED_VALUE"
REBOOT_REQUIRED=1

fi

;;

'Timezone')

REBOOT_REQUIRED=1
dpkg-reconfigure tzdata

;;

'Keyboard')

REBOOT_REQUIRED=1

G_WHIP_MSG 'NB: A keyboard must be physically plugged into the system, before its configuration can be changed.\n\nIf a keyboard is plugged in, please ignore this message. If not, plug one in ;)'
dpkg-reconfigure keyboard-configuration
invoke-rc.d keyboard-setup start
setupcon --save

;;
;;

esac

Expand Down
3 changes: 3 additions & 0 deletions dietpi/patch_file
Original file line number Diff line number Diff line change
Expand Up @@ -2178,6 +2178,9 @@ fdt set /ethernet@$identifier snps,txpbl <0x21>/;q}" /boot/boot.cmd

fi
#-------------------------------------------------------------------------------
# Run "setupcon --save" to force font and cached console+keyboard script renewal. This solves an issue on Buster, where the "console-setup" service fails to do this on boot in cases: https://github.com/MichaIng/DietPi/issues/2912#issuecomment-532100542
setupcon --save
#-------------------------------------------------------------------------------
# Reinstalls and software install changes
if (( $G_DIETPI_INSTALL_STAGE == 2 )); then

Expand Down
2 changes: 1 addition & 1 deletion rootfs/var/lib/dietpi/services/dietpi-firstboot.bash
Original file line number Diff line number Diff line change
Expand Up @@ -153,7 +153,7 @@

G_DIETPI-NOTIFY 2 "Setting Keyboard $autoinstall_keyboard. Please wait..."
G_CONFIG_INJECT 'XKBLAYOUT=' "XKBLAYOUT=\"$autoinstall_keyboard\"" /etc/default/keyboard
#systemctl restart keyboard-setup
setupcon --save

fi

Expand Down

0 comments on commit 07e1b84

Please sign in to comment.