-
-
Notifications
You must be signed in to change notification settings - Fork 927
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Major Highway Builder fixes and improvements. #4999
Conversation
…eout; add timeout check to echest mining
Final thoughts regarding this pr and the module before merging. Comparing highway builder now with previous iterations of the module provides a stark contrast; the feature set has expanded far beyond what I expected feasible. I have run it for hundreds of thousands of blocks to test additions and to fix bugs both old and new, and I am generally confident in the modules stability and performance. With the ability for it now to pull items from shulker boxes or your enderchest, as well as an array of bugfixes, it is possible for it to run for very long periods of time without stopping. Multiple times I've left my room with it enabled, came back over an hour later and it was still running fine. While some issues remain, they are both extremely uncommon and hard to reproduce and resolve - e.g. certain flowing lava patterns on 5 wide diagonals or inventory desyncs. The number and intricacy of the settings has increased a lot, and with that comes both risk and reward. The defaults should work well for most situations but for anyone who actually cares about what they're doing, I would strongly recommend you to test and familiarise yourself with them. It's possible to squeeze out a lot of performance depending on various factors like the amount of resources available and the servers anticheat, and it's also possible to bottleneck yourself or for it to behave in very undesireable ways if you don't pay attention to what you're doing (potentially troublesome ones include As with last time, I did not test it much on strict servers; I would be careful in those environments. Also, if you notice any problems with the module or it behaving unexpectedly, please open an issue here or message me on discord (after making sure it isn't a config issue), and include steps/setups to reproduce it if possible. Have fun building highways out there. |
Type of change
Description
A large amount of changes, fixes and improvements to the module. Unironically more than I can remember off the top of my head, but check below for the highlights. This pr is a draft for now because there are still kinks I need to iron out, and much more testing needs to be done. Hopefully people will be able to look over this with fresh eyes and give feedback. The settings are getting a little out of control, I would like to hear feedback on their layout also.
As with previous changes to this module, they are not particularly designed for strict servers. Furthermore, the rigid nature of the module makes it challenging to account for edge cases, so there are likely to be many issues regarding them present. Please notify if you find one, and include a setup to reproduce it if possible - that will make it much easier to be fixed.
Related issues
closes #4644
closes #4621
closes #4380
closes #3159
closes #3078
closes #1908
How Has This Been Tested?
I will likely attach more media of added features, but here are some of the main ones.
Automatically defusing crystal traps:
java_uCaMutgU0Y.mp4
Restocking from shulkers in your inventory:
java_EdnXouE9kW.mp4
Restocking items from your enderchest:
java_I03Hs3YhHd.mp4
Automatically levelling yourself after falling (I only broke the netherrack, the module placed the blocks and jumped up):
java_ROwRdtODcK.mp4
Double mining, to speed up block breaking tasks.
javaw_IuNRQzRPln.mp4
Checklist: