Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update HighwayBuilder.java #4644

Closed
wants to merge 4 commits into from

Conversation

Blackoutxo
Copy link

@Blackoutxo Blackoutxo commented Jun 14, 2024

Type of change

  • Bug fix

Description

Kind of fixes y-level change issue

Related issues

Mention any issues that this pr relates to.

How Has This Been Tested?

Minecraft_.1.20.6.-.Singleplayer.2024-06-14.18-22-55.-.Trim.mp4

Checklist:

  • My code follows the style guidelines of this project.
  • I have added comments to my code in more complex areas.
  • I have tested the code in both development and production environments.

kind of prevents y-level change
@Blackoutxo
Copy link
Author

Fixes y-level change issue

private void constantAxis(Vec3d initPos) {

// Get to old y-level if offset
if ((int) mc.player.getY() < (int) initPos.getY()) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it really necessary to cast both to int?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not really


} else BlockUtils.breakBlock(mc.player.getBlockPos().up(2), true);

} else if ((int) mc.player.getY() > (int) initPos.getY())
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Again same question

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants