Fix compatibility with Future Client #4454
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I've reimplemented modifyHeight() in PlayerListHudMixin.java to restore mixin compatibility with Future Client, while maintaining full functionality of the BetterTab module in both clients. I tested these changes on Minecraft 1.20.4 with the newest versions of both Future Client and Rusherhack installed. No additional conflicts occurred.
I found a problem with my implementation which caused the tab list to take up more space than needed when the max size option was set to a value larger than the amount of players on your server. This is fixed by using the already-injected collectPlayerEntries() method, instead of referencing the module setting directly.
This was
linked to
issues
Mar 14, 2024
Closed
Closed
tyrannus00
pushed a commit
to tyrannus00/meteor-client
that referenced
this pull request
Apr 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description
I've reimplemented modifyHeight() in PlayerListHudMixin.java to restore mixin compatibility with Future Client and prevent crashes, while maintaining full functionality of the BetterTab module in both clients.
Related issues
This pull request is related to the following issues:
#4422,
#4353,
#4303,
#4141,
#4094
How Has This Been Tested?
I tested these changes on Minecraft version 1.20.4 with the newest versions of both Future Client and Rusherhack installed. No additional conflicts occurred, and both Meteor's BetterTab and Future's ExtraTab function as desired.
This is Meteor's BetterTab on 2b2t:
and this is Future's ExtraTab right afterwards:
Checklist: