Update PlayerListHudMixin.java #4214
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Type of change
* [x] Bug fix
* [ ] New feature
## Description
* Fixes compatibility with Future
* Would love to update 0.5.4 for the 1.20.1 players
# Checklist:
* [x] My code follows the style guidelines of this project.
* [x] I have added comments to my code in more complex areas.
* [x] I have tested the code in both development and production environments.
|
it would be better to have it work alongside future instead of disabling the mixin |
I get that but Future is modifying the same constant and my approach was that it wouldn't really matter if one was at least left with the option from future, I can look for another way to solve this. |
This is accomplished by #4454 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description
Fixes compatiblity with future
Would love to push this of 0.5.4
Checklist: