Remove diagnostics #957
Merged
Remove diagnostics #957
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 52c739a.
|
launch jenkins |
|
launch jenkins |
|
Daint is locked down, but I tested this elsewhere in the docker env and it works. Should be ready for a review whenever you have a chance, @twicki. |
|
launch jenkins |
|
launch jenkins |
|
launch jenkins |
|
launch jenkins |
|
launch jenkins |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Technical Description
Removes the diagnostics objects and generally cleans up printing log messages, e.g. all "raw"
std::coutcalls inside dawn are removed and replaced by general ostreams that are hooked up to use thedawn::log::{info,warn,error}.stream()std::ostreams.Resolves / Enhances
Resolves #950.
Dependencies
Depends on #955 and #956.