Replace logger #955
Merged
Replace logger #955
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
|
launch jenkins |
|
launch jenkins |
|
launch jenkins |
|
launch jenkins |
|
launch jenkins |
jdahm
commented
May 8, 2020
| @@ -234,8 +234,8 @@ bool PassRemoveScalars::run( | |||
| // Check if we have unsupported statements. If we do, warn the user and skip the pass execution. | |||
| for(const auto& stmt : iterateIIROverStmt(*stencilInstantiation->getIIR())) { | |||
| if(isStatementUnsupported(stmt, stencilInstantiation->getMetaData())) { | |||
| DAWN_LOG(INFO) << "Unsupported statement at line " << stmt->getSourceLocation() | |||
| << ". Skipping removal of scalar variables."; | |||
| DAWN_DIAG(INFO, stencilInstantiation->getMetaData().getFileName(), stmt->getSourceLocation()) | |||
There was a problem hiding this comment.
Here is an example of the diagnostic in code.
There was a problem hiding this comment.
is the idea to not switch in this but in a follow up PR?
jdahm
commented
May 8, 2020
| std::cout << "PASS: " << getName() << ": " << stencilInstantiation->getName() | ||
| << ": DoMethod: " << doMethod->getID() << " removed variable: " << varName | ||
| << std::endl; | ||
| DAWN_LOG(INFO) << stencilInstantiation->getName() << ": DoMethod: " << doMethod->getID() |
There was a problem hiding this comment.
Switched to DAWN_LOG(INFO) instead.
jdahm
commented
May 8, 2020
| break; | ||
| case google::protobuf::LOGLEVEL_FATAL: | ||
| DAWN_LOG(FATAL) << "Protobuf: " << message; | ||
| throw SyntacticError(std::string("[FATAL] Protobuf error occurred: ") + message); |
There was a problem hiding this comment.
This should match the other error before merging.
|
launch jenkins |
twicki
approved these changes
May 12, 2020
| std::cout << "PASS: " << getName() << ": " << stencilInstantiation->getName() | ||
| << ": DoMethod: " << doMethod->getID() << " removed variable: " << varName | ||
| << std::endl; | ||
| DAWN_LOG(INFO) << stencilInstantiation->getName() << ": DoMethod: " << doMethod->getID() |
| @@ -234,8 +234,8 @@ bool PassRemoveScalars::run( | |||
| // Check if we have unsupported statements. If we do, warn the user and skip the pass execution. | |||
| for(const auto& stmt : iterateIIROverStmt(*stencilInstantiation->getIIR())) { | |||
| if(isStatementUnsupported(stmt, stencilInstantiation->getMetaData())) { | |||
| DAWN_LOG(INFO) << "Unsupported statement at line " << stmt->getSourceLocation() | |||
| << ". Skipping removal of scalar variables."; | |||
| DAWN_DIAG(INFO, stencilInstantiation->getMetaData().getFileName(), stmt->getSourceLocation()) | |||
There was a problem hiding this comment.
is the idea to not switch in this but in a follow up PR?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Technical Description
Replace Logger by a similar but improved infrastructure.
A follow-up PR will replace the diagnostics with this.
The Logger design is similar to before, however there are separate loggers
dawn::log::info,dawn::log::warning, anddawn::log::errorwhich are globals similar tostd::coutandstd::cerr.Each logger has an
LoggerProxy operator()(string, int)as before that returns the stream operatorEach logger also acts as a container that stores the messages (a la
DiagnosticsEngine).Instead of a virtual LoggerInterface that potentially leaks memory when registering other class instance pointers, this is replaced with a lightweight std::function object
Logger::Formatter, so GTClang and other frameworks can register their own message formatting.Loggers also take underlying
std::ostreams, which can be customized to write to strings, files, etc.Resolves / Enhances
Part of #950.
Testing
Integrates into ctest.