Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New Kadena #860

Merged
merged 7 commits into from
Oct 21, 2024
Merged

New Kadena #860

merged 7 commits into from
Oct 21, 2024

Conversation

khanti42
Copy link
Collaborator

@khanti42 khanti42 commented Oct 8, 2024 •
edited
Loading

Closes: #861

@khanti42 khanti42 changed the title New kadena New Kadena Oct 8, 2024
@khanti42 khanti42 marked this pull request as ready for review October 8, 2024 13:42
@khanti42 khanti42 requested review from Montoya and a team as code owners October 8, 2024 13:42
@khanti42 khanti42 marked this pull request as draft October 8, 2024 16:17
@khanti42
Copy link
Collaborator Author

khanti42 commented Oct 8, 2024 •
edited
Loading

Putting this as draft. It needs this PR MetaMask/metamask-extension#27376 to go to PROD.
Checking with the builder if they can remove the directory field till then. Otherwise this Snap will have to wait to be allowlisted.

@khanti42 khanti42 marked this pull request as ready for review October 9, 2024 15:28
@FrederikBolding FrederikBolding merged commit b734054 into main Oct 21, 2024
16 checks passed
@FrederikBolding FrederikBolding deleted the newKadena branch October 21, 2024 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mario-christopher mario-christopher mario-christopher approved these changes

@FrederikBolding FrederikBolding FrederikBolding approved these changes

@Montoya Montoya Montoya approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[New Snap] Kadena
4 participants
@khanti42 @Montoya @FrederikBolding @mario-christopher