chore: Bump Snaps packages #27376
Merged
chore: Bump Snaps packages #27376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@metamaskbot update-policies |
|
Policy update failed. You can review the logs or retry the policy update here |
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
This was referenced Oct 8, 2024
|
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: npm/@metamask/[email protected], npm/@metamask/[email protected], npm/@metamask/[email protected], npm/@metamask/[email protected], npm/@metamask/[email protected] |
Builds ready [4e994b4]
Page Load Metrics (1752 ± 67 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Builds ready [7c18e47]
Page Load Metrics (1814 ± 85 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Mrtenz
force-pushed
the
mrtenz/bump-snaps-packages
branch
3 times, most recently
from
0434349
to
86d70c2
Compare
GuillaumeRx
previously approved these changes
Oct 15, 2024
|
@metamaskbot update-policies |
|
No policy changes |
Builds ready [893d11b]
Page Load Metrics (1974 ± 110 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
## **Description** Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? Previously, developers couldn't navigate to parts of the extension with the existing functionality provided to them through snaps UI 2. What is the improvement/solution? The Snaps `Link` component now checks for if the url is a MetaMask url and navigates to the proper path accordingly. ## **Screenshots/Recordings** ### **After** ## **Pre-merge author checklist** - [ ] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
## **Description This PR adds support for the `size` prop to the `Heading` component. Right now `md` is bind to `headingMd`, `lg` is bind to `headingLg` to match https://www.figma.com/design/2cqqTWJKoHcjYVGfNXxLbQ/Beyond-Ethereum?node-id=3458-5041&node-type=text&m=dev as requested by @eriknson. The default behavior if `size` is not defined si `headingSm` [](https://codespaces.new/MetaMask/metamask-extension/pull/27721?quickstart=1) ## **Related issues** ## **Manual testing steps** ## **Pre-merge author checklist** - [ ] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
## **Description** This adds the `min`, `max` and `step` props to the `Input` component of Snaps custom UI. [](https://codespaces.new/MetaMask/metamask-extension/pull/27822?quickstart=1) ## **Related issues** ## **Manual testing steps** ## **Screenshots/Recordings** ## **Pre-merge author checklist** - [ ] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
## **Description** This PR adds a case for the `sm` variant of the `size` prop in the `Heading` Snaps custom UI component. [](https://codespaces.new/MetaMask/metamask-extension/pull/27823?quickstart=1) ## **Related issues** ## **Manual testing steps** ## **Screenshots/Recordings** ## **Pre-merge author checklist** - [ ] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. --------- Co-authored-by: Hassan Malik <[email protected]>
<!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** Move Snaps UI avatar implementation to a separate component that can be consumed by Snaps. [](https://codespaces.new/MetaMask/metamask-extension/pull/27826?quickstart=1) ## **Related issues** Closes: MetaMask/snaps#2776 ## **Manual testing steps** ```jsx export const onRpcRequest: OnRpcRequestHandler = async ({ origin, request, }) => { switch (request.method) { case 'hello': return snap.request({ method: 'snap_dialog', params: { type: 'confirmation', content: ( <Box> <Text> Hello, <Bold>{origin}</Bold>! </Text> <Text> This custom confirmation is just for display purposes. </Text> <Text> But you can edit the snap source code to make it do something, if you want to! </Text> <Address address='eip155:1:0x1234567890123456789012345678901234567890' /> <Avatar address="eip155:1:0x1234567890123456789012345678901234567890" /> <Address address="bip122:000000000019d6689c085ae165831e93:128Lkh3S7CkDTBZ8W7BbpsN3YYizJMp8p6" /> <Avatar address="bip122:000000000019d6689c085ae165831e93:128Lkh3S7CkDTBZ8W7BbpsN3YYizJMp8p6" /> <Box direction="horizontal" alignment="space-between" center={true}> <Text>Avatar</Text> <Avatar address="bip122:000000000019d6689c085ae165831e93:128Lkh3S7CkDTBZ8W7BbpsN3YYizJMp8p6" /> </Box> </Box> ), }, }); default: throw new Error('Method not found.'); } }; ``` ## **Screenshots/Recordings** <img width="387" alt="Screenshot 2024-10-14 at 14 44 50" src="https://github.com/user-attachments/assets/e06a0aca-0aeb-4004-9290-d700867b4eff">
## **Description** This PR fixes a type issue on custom UI `Input` component. [](https://codespaces.new/MetaMask/metamask-extension/pull/27860?quickstart=1) ## **Related issues** ## **Manual testing steps** ## **Screenshots/Recordings** ## **Pre-merge author checklist** - [ ] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
Mrtenz
force-pushed
the
mrtenz/bump-snaps-packages
branch
from
893d11b
to
7598b3a
Compare
GuillaumeRx
previously approved these changes
Oct 15, 2024
ritave
previously approved these changes
Oct 15, 2024
Builds ready [7598b3a]
Page Load Metrics (1833 ± 92 ms)
|
FrederikBolding
approved these changes
Oct 16, 2024
GuillaumeRx
approved these changes
Oct 16, 2024
|
|
LGTM ✅ |
](https://codespaces.new/MetaMask/metamask-extension/pull/27721?quickstart=1){kind=link}
](https://codespaces.new/MetaMask/metamask-extension/pull/27822?quickstart=1){kind=link}
](https://codespaces.new/MetaMask/metamask-extension/pull/27823?quickstart=1){kind=link}
](https://codespaces.new/MetaMask/metamask-extension/pull/27826?quickstart=1){kind=link}
](https://codespaces.new/MetaMask/metamask-extension/pull/27860?quickstart=1){kind=link}
Builds ready [a756f10]
Page Load Metrics (1753 ± 77 ms)
|
metamaskbot
added
the
release-12.7.0
gauthierpetetin
added
release-12.6.0
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This bumps all Snaps packages to the latest versions.
Summary of changes in the snaps deps:
contextinsnap_updateInterfacesnap_getCurrencyRateRPC methodAvatarcomponentmin,maxandstepprops toInputcomponentsizeprop toHeadingcomponentmetamask:schemed URLs in Snap UI linksLinkinRowandAddressinLinkCloses MetaMask/snaps#2776
Pre-merge author checklist
Pre-merge reviewer checklist