Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support overriding Duplex stream options as constructor options #131

Merged
merged 6 commits into from
May 15, 2024

Conversation

legobeat
Copy link
Contributor

@legobeat legobeat commented May 15, 2024

Adds recognition (including types) of stream DuplexOptions in all stream classes. Any options not explicitly handled in implementing classes are forwarded through BaseMessageStream to the base Duplex class. Current defaults are retained.

See also

@legobeat legobeat requested a review from rekmarks May 15, 2024 04:24
@legobeat legobeat changed the title feat: Support Duplex stream options as constructor options feat: Support overriding Duplex stream options as constructor options May 15, 2024
@legobeat legobeat requested review from Mrtenz and weizman May 15, 2024 05:22
Copy link
Member

@rekmarks rekmarks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@legobeat legobeat merged commit e3e759b into MetaMask:main May 15, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants