Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Allow overriding default Stream options #110

Merged
merged 4 commits into from
May 15, 2024
Merged

feat: Allow overriding default Stream options #110

merged 4 commits into from
May 15, 2024

Conversation

legobeat
Copy link
Contributor

@legobeat legobeat commented May 15, 2024 •
edited
Loading

  • feat: Allow overriding stream constructor options in storeTransformStream
  • feat: Allow overriding stream constructor options in ObservableStoreStream constructor
  • feat: Allow overriding stream constructor options in storeAsStream function
  • chore: add @types/readable-stream
    • See commit message for details and object-multiplex for another package in a similar situation already using the same approach
  • chore: update @types/node from v10 to v14

@legobeat legobeat requested a review from a team as a code owner May 15, 2024 03:00
@socket-security Socket Security
Copy link

socket-security bot commented May 15, 2024 •
edited
Loading

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@types/[email protected] None 0 1.61 MB types
npm/@types/[email protected] None +1 56.6 kB types
npm/[email protected] None 0 73.1 kB ethan_arrowood

🚮 Removed packages: npm/@types/[email protected]

View full report↗︎

@legobeat legobeat requested a review from a team May 15, 2024 03:00
@legobeat legobeat changed the title fest: Allow overriding default Stream options feat: Allow overriding default Stream options May 15, 2024
legobeat added 4 commits May 15, 2024 03:04
@legobeat
chore(devDeps): add @types/readable-stream
ec1db7c 
- @types/readable-stream v3 does not exist
- @types/readable-stream 4.0.0 maps to v3 except missing function
- @types/readable-stream >4.0.0 not compatible with readable-stream v3
@legobeat
fix: update @types/node from v10 to v14
42f53fd
@legobeat
feat: allow overriding stream constructor options in storeTransformSt…
4b0dcd7 
…ream
@legobeat
feat: allow overriding stream constructor options for ObservableStore…
d3e5052 
…Stream
@legobeat legobeat requested review from kumavis, mcmire and Gudahtt May 15, 2024 03:05
This was referenced May 15, 2024
Draft
Merged
@legobeat legobeat requested review from rekmarks, naugtur and weizman May 15, 2024 06:13
rekmarks
rekmarks approved these changes May 15, 2024
View reviewed changes
Copy link
Member

@rekmarks rekmarks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@legobeat legobeat merged commit 5d43cde into MetaMask:main May 15, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rekmarks rekmarks rekmarks approved these changes

@kumavis kumavis Awaiting requested review from kumavis

@mcmire mcmire Awaiting requested review from mcmire

@Gudahtt Gudahtt Awaiting requested review from Gudahtt

@naugtur naugtur Awaiting requested review from naugtur

@weizman weizman Awaiting requested review from weizman

Assignees
No one assigned
Labels
None yet
Projects
PR review queue
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@legobeat @rekmarks