[UPDATE] - Yarn Audit Updates #5978
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… production value since the project is stilll maintained
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
3 tasks
legobeat
reviewed
Apr 21, 2023
| @@ -1,2 +1,3 @@ | |||
| GHSA-p8p7-x288-28g6 | |||
There was a problem hiding this comment.
@sethkfman @tommasini How was the assessment made that this is not a vulnerability for MM Mobile? It looks like this can actually breaks TLS security by a protocol redirect?
This was patched in extension: MetaMask/metamask-extension#18208
If the request package is indeed staying for now, perhaps we can consider moving to the more recently maintained cypress fork with this fix: cypress-io/request#28
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Development & PR Process
release-xxlabel to identify the PR slated for a upcoming release (will be used in release discussion)needs-dev-reviewlabel when work is completedneeds-qalabel when dev review is completedQA Passedlabel when QA has signed offDescription
This is a fix and update to the
.iyarcfile used for excluding yarn audit elements. Old audits that were no longer valid have been removed.A new audit was added for exclusion per the warning we are maintain our project and there is currently no patch.
(Ref: GHSA-p8p7-x288-28g6)
Screenshots/Recordings
NA
Issue
Progresses #???
Checklist