Revert Relative Path for EditGas #5973
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
blackdevelopa
commented
Mar 16, 2023
blackdevelopa
commented
Mar 16, 2023
blackdevelopa
added
the
needs-dev-review
jpuri
approved these changes
Mar 16, 2023
Cal-L
added
regression-RC
|
QA'd the changes and looks that the issue is fixed.
mobile-edit-gas.mp4 |
Cal-L
approved these changes
Mar 16, 2023
Cal-L
removed
the
needs-dev-review
|
@sethkfman has a PR for the failing audit, here. We can cherrypick after merge to main. |
Cal-L
force-pushed
the
rc_blocker_approve
branch
from
ebaf499 to
40c8056
Compare
cryptotavares
added
team-confirmations-secure-ux
chrisleewilcox
removed
the
regression-RC
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Development & PR Process
release-xxlabel to identify the PR slated for a upcoming release (will be used in release discussion)needs-dev-reviewlabel when work is completedneeds-qalabel when dev review is completedQA Passedlabel when QA has signed offDescription
Revert relative path for gas modal for approve transaction. Fixes #719
Screenshots/Recordings
http://recordit.co/JwkaNlx5ze
If applicable, add screenshots and/or recordings to visualize the before and after of your change
Issue
Progresses https://github.com/MetaMask/mobile-planning/issues/719
Checklist