-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(11215): show error message when user selects a new ledger device #12127
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #12127 +/- ##
==========================================
+ Coverage 55.78% 56.20% +0.42%
==========================================
Files 1786 1786
Lines 40362 40373 +11
Branches 5054 5058 +4
==========================================
+ Hits 22516 22693 +177
+ Misses 16297 16126 -171
- Partials 1549 1554 +5 ☔ View full report in Codecov by Sentry. |
…orgetting a device (#86) <!-- Thanks for your contribution! Take a moment to answer these questions so that reviewers have the information they need to properly understand your changes: * What is the current state of things and why does it need to change? * What is the solution your changes offer and how does it work? Are there any issues or other links reviewers should consult to understand this pull request better? For instance: * Fixes #12345 * See: #67890 --> Currently when we call forgetDevice function from ledger keyring, it doesn't clear up the stored `deviceId`. This could be a blocker when checking for existing stored `deviceId` client side. Then, this will unblock a [fix for multiple devices handling](MetaMask/metamask-mobile#12127) as [an issue has been found during QA testing](MetaMask/metamask-mobile#11215 (comment)) related to `deviceId`.
Quality Gate passedIssues Measures |
Tested using bitrise build on iOS 18.0.1/Android 14 and error is displayed correctly. ScreenRecording_11-13-2024.16-02-53_1.MP4 |
Description
As discussed with @AlexJupiter, to prevent users to add multiple ledger devices, we decided to show an error message when deviceId would not match with the device already added.
This is a temporary solution until proper mutliple devices support is implemented.
Related issues
Fixes: #11215
Manual testing steps
Screenshots/Recordings
Before
After
video_2024-11-04_14-29-58.mp4
Pre-merge author checklist
Pre-merge reviewer checklist